From: "Michael Chan" <mchan@broadcom.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: akepner@sgi.com, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6.12-rc2 3/3] tg3: Fix tg3_restart_ints()
Date: Mon, 25 Apr 2005 14:56:25 -0700 [thread overview]
Message-ID: <1114466185.4917.61.camel@rh4> (raw)
In-Reply-To: <20050425151816.1910b2ba.davem@davemloft.net>
On Mon, 2005-04-25 at 15:18 -0700, David S. Miller wrote:
> All 3 patches applied, looks great.
>
> The only thing I see is that we might want to put a
> rmb() at the beginning of tg3_has_work() since we are
> clearing the status block bit right before we call it.
> It might not be necessary though.
>
I think memory barriers are not needed since tg3_has_work() does not
depend on what's been written or read before it, other than sblk->status
which is a direct dependency.
next prev parent reply other threads:[~2005-04-25 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1114463061.4917.34.camel@rh4>
2005-04-25 21:09 ` [PATCH 2.6.12-rc2 2/3] tg3: Refresh hw index in tg3_rx() Michael Chan
[not found] ` <1114464194.4917.52.camel@rh4>
[not found] ` <20050425151816.1910b2ba.davem@davemloft.net>
2005-04-25 21:56 ` Michael Chan [this message]
[not found] ` <20050425162416.2b4edd43.davem@davemloft.net>
[not found] ` <1114470490.4917.85.camel@rh4>
2005-05-05 23:05 ` [PATCH 2.6.12-rc2 3/3] tg3: Fix tg3_restart_ints() David S. Miller
2005-05-05 22:51 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114466185.4917.61.camel@rh4 \
--to=mchan@broadcom.com \
--cc=akepner@sgi.com \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).