netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jamal Hadi Salim <hadi@znyx.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@oss.sgi.com
Subject: patch: policy update by id
Date: Wed, 27 Apr 2005 07:54:34 -0400	[thread overview]
Message-ID: <1114602874.7670.4.camel@localhost.localdomain> (raw)

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]


Herbert,

I think this is a reasonable thing to have. I should be able to update
(just like delete or get) a policy by id. And that it trumps a selector
when both are specified..
I am assuming ids are unique - otherwise we have a serious problem.
If this patch looks good, please add it to your patch collection that
you are queueing for Dave; btw - is that stuff supposed to show up
around .13?

cheers,
jamal

[-- Attachment #2: polid_p --]
[-- Type: text/plain, Size: 539 bytes --]

--- a/net/xfrm/xfrm_policy.c	2005/04/27 11:32:13	1.1
+++ b/net/xfrm/xfrm_policy.c	2005/04/27 11:48:42
@@ -345,7 +345,9 @@
 
 	write_lock_bh(&xfrm_policy_lock);
 	for (p = &xfrm_policy_list[dir]; (pol=*p)!=NULL;) {
-		if (!delpol && memcmp(&policy->selector, &pol->selector, sizeof(pol->selector)) == 0) {
+		if (!delpol && 
+		((!excl && policy->id && (policy->id == pol->id)) || 
+		 (memcmp(&policy->selector, &pol->selector, sizeof(pol->selector)) == 0))) {
 			if (excl) {
 				write_unlock_bh(&xfrm_policy_lock);
 				return -EEXIST;

             reply	other threads:[~2005-04-27 11:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-27 11:54 Jamal Hadi Salim [this message]
2005-04-27 12:18 ` patch: policy update by id Patrick McHardy
2005-04-27 12:28   ` Jamal Hadi Salim
2005-04-27 12:52     ` jamal
2005-04-27 12:24 ` jamal
2005-04-27 12:27   ` Jamal Hadi Salim
2005-04-27 23:39     ` Herbert Xu
2005-04-28  1:13       ` jamal
2005-04-28  1:21         ` Herbert Xu
2005-04-28  1:30           ` Herbert Xu
2005-04-28  1:52             ` jamal
2005-04-28  2:07               ` Herbert Xu
2005-04-28  2:20                 ` jamal
2005-04-28  2:22                   ` Herbert Xu
2005-04-28  2:29                     ` jamal
2005-04-28  2:43                 ` David S. Miller
2005-04-28  2:56                   ` Herbert Xu
2005-04-28  3:16                     ` jamal
2005-04-28  3:20                       ` Herbert Xu
2005-04-28 11:43                         ` Thomas Graf
2005-04-28 12:09                           ` Patrick McHardy
2005-04-28 12:33                             ` Thomas Graf
2005-04-28  3:09                   ` jamal
2005-04-28  1:44           ` jamal
2005-04-28  1:48             ` Herbert Xu
2005-04-28  1:59               ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1114602874.7670.4.camel@localhost.localdomain \
    --to=hadi@znyx.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).