From: jamal <hadi@cyberus.ca>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@oss.sgi.com
Subject: Re: patch: policy update by id
Date: Wed, 27 Apr 2005 21:59:54 -0400 [thread overview]
Message-ID: <1114653595.7663.45.camel@localhost.localdomain> (raw)
In-Reply-To: <20050428014818.GA23148@gondor.apana.org.au>
On Thu, 2005-28-04 at 11:48 +1000, Herbert Xu wrote:
> On Wed, Apr 27, 2005 at 09:44:40PM -0400, jamal wrote:
> >
> > > I see. In that case you want to change your expression above
> > > so that the memcmp is never done if excl is off and the index
> > > is non-zero.
> >
> > Hrm. Thinking... So you want to exclude the selector check if someone
> > updating ever specified the index? That may change things a little, no?
> > Give me a clever expression.
>
> Please see my last email.
And you my other email ;->
> To do index updates correctly we'll need
> to modify the current code so that it is able to delete two existing
> policies. We may have two existing policies if one matches the index
> while the other matches the selector.
>
i think if we say index is unique per direction then lets settle in
rejecting adds which try to reinsert the same index. So theres no
ambiguity in deleting by index.
Not specifying the index means one which is unique is generated by the
kernel.
Specifying x rules with exact same selector in absence of a index i
believe should be allowed. There the disambiguation in add is via the
priority. Deleting of such entries should be per first seen i.e highest
priority.
Thoughts?
cheers,
jamal
prev parent reply other threads:[~2005-04-28 1:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-27 11:54 patch: policy update by id Jamal Hadi Salim
2005-04-27 12:18 ` Patrick McHardy
2005-04-27 12:28 ` Jamal Hadi Salim
2005-04-27 12:52 ` jamal
2005-04-27 12:24 ` jamal
2005-04-27 12:27 ` Jamal Hadi Salim
2005-04-27 23:39 ` Herbert Xu
2005-04-28 1:13 ` jamal
2005-04-28 1:21 ` Herbert Xu
2005-04-28 1:30 ` Herbert Xu
2005-04-28 1:52 ` jamal
2005-04-28 2:07 ` Herbert Xu
2005-04-28 2:20 ` jamal
2005-04-28 2:22 ` Herbert Xu
2005-04-28 2:29 ` jamal
2005-04-28 2:43 ` David S. Miller
2005-04-28 2:56 ` Herbert Xu
2005-04-28 3:16 ` jamal
2005-04-28 3:20 ` Herbert Xu
2005-04-28 11:43 ` Thomas Graf
2005-04-28 12:09 ` Patrick McHardy
2005-04-28 12:33 ` Thomas Graf
2005-04-28 3:09 ` jamal
2005-04-28 1:44 ` jamal
2005-04-28 1:48 ` Herbert Xu
2005-04-28 1:59 ` jamal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114653595.7663.45.camel@localhost.localdomain \
--to=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).