netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* patch2: del/get byid
@ 2005-04-28  2:11 jamal
  2005-04-28  2:14 ` Herbert Xu
  0 siblings, 1 reply; 19+ messages in thread
From: jamal @ 2005-04-28  2:11 UTC (permalink / raw)
  To: Herbert Xu; +Cc: David S. Miller, netdev

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]


This is definetely a bug. It doesnt seem like get/del by index worked.
For some reason i thought i tested this before and it worked.

cheers,
jamal

[-- Attachment #2: polid_p3 --]
[-- Type: text/plain, Size: 400 bytes --]

--- a/net/xfrm/xfrm_policy.c	2005/04/27 15:35:50	1.2
+++ b/net/xfrm/xfrm_policy.c	2005/04/27 20:23:07
@@ -417,7 +417,7 @@
 	struct xfrm_policy *pol, **p;
 
 	write_lock_bh(&xfrm_policy_lock);
-	for (p = &xfrm_policy_list[id & 7]; (pol=*p)!=NULL; p = &pol->next) {
+	for (p = &xfrm_policy_list[dir]; (pol=*p)!=NULL; p = &pol->next) {
 		if (pol->index == id) {
 			xfrm_pol_hold(pol);
 			if (delete)

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2005-04-30  1:08 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-28  2:11 patch2: del/get byid jamal
2005-04-28  2:14 ` Herbert Xu
2005-04-28  2:23   ` jamal
2005-04-28  2:25     ` Herbert Xu
2005-04-28  2:39       ` jamal
2005-04-28  2:42         ` Herbert Xu
2005-04-28  2:55           ` jamal
2005-04-28  3:03             ` Herbert Xu
2005-04-28  3:24               ` jamal
2005-04-28 14:20                 ` jamal
2005-04-28 23:11                   ` Herbert Xu
2005-04-29 12:51                     ` jamal
2005-04-29 23:20                       ` jamal
2005-04-29 23:49                         ` Herbert Xu
2005-04-30  0:01                           ` jamal
2005-04-30  0:12                             ` Herbert Xu
2005-04-30  0:35                               ` jamal
2005-04-30  0:47                                 ` Herbert Xu
2005-04-30  1:08                                   ` jamal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).