Re: patch2: del/get byid

[jamal <hadi@cyberus.ca>]

On Fri, 2005-29-04 at 09:11 +1000, Herbert Xu wrote:

> Now that you are allowing the user to set the index, this excl check
> really needs to go.  Otherwise the user can add two policies with
> the same index.

Agreed.

> 
> You also still need to solve the problem that you may need to
> delete two policies if one matches the index while the other matches
> the selector (or selector plus priority if you do that).
> 

Ok, this bit is tricky...  that is unless we disallowed it from
happening in the first place maybe

i.e something along the lines of:

delp1 = find by index
delp2 = find by selector
if delp1 && delp2 and delp1 != delp2
return -EINVAL

// so far good. check the add case
if delp1 || delp2 and excl
return -EEXIST
        
do the insert here based on priority ..

Thoughts?

cheers,
jamal