From: jamal <hadi@cyberus.ca>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
netdev@oss.sgi.com, "David S. Miller" <davem@davemloft.net>
Subject: Re: patch2: del/get byid
Date: Fri, 29 Apr 2005 20:01:21 -0400 [thread overview]
Message-ID: <1114819281.8929.9.camel@localhost.localdomain> (raw)
In-Reply-To: <20050429234952.GB22699@gondor.apana.org.au>
On Sat, 2005-30-04 at 09:49 +1000, Herbert Xu wrote:
> On Fri, Apr 29, 2005 at 07:20:46PM -0400, jamal wrote:
>
> > write_unlock_bh(&xfrm_policy_lock);
> >
> > - if (delpol) {
> > - xfrm_policy_kill(delpol);
> > + if (delp) {
> > + xfrm_policy_kill(delp);
> > }
>
> This is racy. The policy could be killed by the timer in the middle.
>
the policy_kill is?
> This is also getting pretty hairy for something that nobody has needed so
> far. Which user-space application is going to use this index thing?
did you see the attachment i put with ip x tests?
cheers,
jamal
next prev parent reply other threads:[~2005-04-30 0:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-28 2:11 patch2: del/get byid jamal
2005-04-28 2:14 ` Herbert Xu
2005-04-28 2:23 ` jamal
2005-04-28 2:25 ` Herbert Xu
2005-04-28 2:39 ` jamal
2005-04-28 2:42 ` Herbert Xu
2005-04-28 2:55 ` jamal
2005-04-28 3:03 ` Herbert Xu
2005-04-28 3:24 ` jamal
2005-04-28 14:20 ` jamal
2005-04-28 23:11 ` Herbert Xu
2005-04-29 12:51 ` jamal
2005-04-29 23:20 ` jamal
2005-04-29 23:49 ` Herbert Xu
2005-04-30 0:01 ` jamal [this message]
2005-04-30 0:12 ` Herbert Xu
2005-04-30 0:35 ` jamal
2005-04-30 0:47 ` Herbert Xu
2005-04-30 1:08 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114819281.8929.9.camel@localhost.localdomain \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).