From: jamal <hadi@cyberus.ca>
To: Patrick McHardy <kaber@trash.net>
Cc: "David S. Miller" <davem@davemloft.net>,
Maillist netdev <netdev@oss.sgi.com>
Subject: Re: [NET]: Avoid useless iterating in netlink dump functions
Date: Fri, 06 May 2005 17:04:33 -0400 [thread overview]
Message-ID: <1115413473.13922.38.camel@localhost.localdomain> (raw)
In-Reply-To: <427B8FC3.4000305@trash.net>
On Fri, 2005-06-05 at 17:39 +0200, Patrick McHardy wrote:
> This patch changes a couple of places like this:
>
> for (h = 0; h <= tbl->hash_mask; h++) {
> if (h < s_h)
> continue;
>
> to this:
>
> for (h = s_h; h <= tbl->hash_mask; h++) {
>
> The only difference is that we can now get past the loop with
> h > tbl->hash_mask if hash_mask was decreased between two callbacks
> and h was already past the new value. But it still behaves identical,
> nothing is dumped.
>
Looks good - you may also wanna treat tcf_dump_walker() and
xfrm_dump_sa() the same way then.
cheers,
jamal
next prev parent reply other threads:[~2005-05-06 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-06 15:39 [NET]: Avoid useless iterating in netlink dump functions Patrick McHardy
2005-05-06 21:04 ` jamal [this message]
2005-05-06 21:12 ` Patrick McHardy
2005-05-06 21:17 ` jamal
2005-05-06 21:27 ` Patrick McHardy
2005-05-07 12:10 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1115413473.13922.38.camel@localhost.localdomain \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).