From: jamal <hadi@cyberus.ca>
To: Patrick McHardy <kaber@trash.net>
Cc: "David S. Miller" <davem@davemloft.net>,
Maillist netdev <netdev@oss.sgi.com>
Subject: Re: [NET]: Avoid useless iterating in netlink dump functions
Date: Sat, 07 May 2005 08:10:39 -0400 [thread overview]
Message-ID: <1115467839.19561.14.camel@localhost.localdomain> (raw)
In-Reply-To: <427BE147.9080508@trash.net>
On Fri, 2005-06-05 at 23:27 +0200, Patrick McHardy wrote:
> jamal wrote:
> > On Fri, 2005-06-05 at 23:12 +0200, Patrick McHardy wrote:
> >
> >>action dumping is on my list for more treatment than this :)
> >
> > Well, that does sound scary ;-> What do you have in mind.
> > Recall, there are two paths to dumping actions - unlike any other thing
> > in the kernel.
>
> Don't worry :) Its actually action walking that is on my list.
> What I have planed is roughly:
> - clean up and move hashing functions to act_common.c
> - put data needed for hashing (size, pointer to memory, ...) in
> struct tc_act_common, which is referenced by struct tc_action_ops
> - add callback based walking function so we don't need two of them
>
> This should also get rid of all the large functions contained in
> headerfiles.
>
Ah, ok ;->
Weve discussed this already - I think DaveM already took in the simple
action patch that i posted a while back; it doesnt seem like you will
collide with that - just double check.
cheers,
jamal
prev parent reply other threads:[~2005-05-07 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-06 15:39 [NET]: Avoid useless iterating in netlink dump functions Patrick McHardy
2005-05-06 21:04 ` jamal
2005-05-06 21:12 ` Patrick McHardy
2005-05-06 21:17 ` jamal
2005-05-06 21:27 ` Patrick McHardy
2005-05-07 12:10 ` jamal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1115467839.19561.14.camel@localhost.localdomain \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).