netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Chan" <mchan@broadcom.com>
To: davem@davemloft.net
Cc: jgarzik@pobox.com, netdev@oss.sgi.com
Subject: [PATCH 0/6] bnx2: Misc fixes
Date: Mon, 23 May 2005 16:53:59 -0700	[thread overview]
Message-ID: <1116892439.4908.1.camel@rh4> (raw)

These patches fix the following problems spotted by Jeff Garzik. Thanks
Jeff.

> 8) excessive stack size in bnx2_alloc_bad_rbuf():

> 13) [additional review] why is CHECKSUM_UNNECESSARY used when
> cksum==0xffff or cksum==0 ?

> 15) the following loop is just silly.  use mdelay or (preferably)
> msleep.

> 19) [additional review] need flush_scheduled_work(), if using work
queues?

> 21) need to call bnx2_netif_stop() in bnx2_close()

             reply	other threads:[~2005-05-23 23:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-23 23:53 Michael Chan [this message]
2005-05-24  0:25 ` [PATCH 1/6] bnx2: Fix excessive stack usage Michael Chan
2005-05-24  1:42   ` Jeff Garzik
2005-05-24  4:29     ` Michael Chan
2005-05-24  5:43       ` Jeff Garzik
2005-05-25 22:18         ` David S. Miller
2005-05-24  0:26 ` [PATCH 2/6] bnx2: Fix rx checksum Michael Chan
2005-05-24  0:27 ` [PATCH 3/6] bnx2: Fix excessive udelay Michael Chan
2005-05-24  0:29 ` [PATCH 4/6] bnx2: Fix bug in bnx2_close Michael Chan
2005-05-24  0:29 ` [PATCH 5/6] bnx2: Add bnx2 prefix and mark static Michael Chan
2005-05-24  0:30 ` [PATCH 6/6] bnx2: Update revision and reldate Michael Chan
2005-05-24  1:48 ` [PATCH 0/6] bnx2: Misc fixes Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1116892439.4908.1.camel@rh4 \
    --to=mchan@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=jgarzik@pobox.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).