From: "Michael Chan" <mchan@broadcom.com>
To: davem@davemloft.net
Cc: jgarzik@pobox.com, netdev@oss.sgi.com
Subject: [PATCH 4/6] bnx2: Fix bug in bnx2_close
Date: Mon, 23 May 2005 17:29:03 -0700 [thread overview]
Message-ID: <1116894543.4908.32.camel@rh4> (raw)
In-Reply-To: <1116892439.4908.1.camel@rh4>
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
Fix bug in bnx2_close() by calling flush_scheduled_work() since we are
using a work queue in netdev watchdog. Also added bnx2_netif_stop() call
in bnx2_close().
Spotted by Jeff Garzik.
Signed-off-by: Michael Chan <mchan@broadcom.com>
[-- Attachment #2: bnx2-14.patch --]
[-- Type: text/x-patch, Size: 434 bytes --]
diff -Nru 13/drivers/net/bnx2.c 14/drivers/net/bnx2.c
--- 13/drivers/net/bnx2.c 2005-05-23 10:57:41.000000000 -0700
+++ 14/drivers/net/bnx2.c 2005-05-23 13:01:45.000000000 -0700
@@ -4172,7 +4172,8 @@
struct bnx2 *bp = dev->priv;
u32 reset_code;
- bnx2_disable_int_sync(bp);
+ flush_scheduled_work();
+ bnx2_netif_stop(bp);
del_timer_sync(&bp->timer);
if (bp->wol)
reset_code = BNX2_DRV_MSG_CODE_SUSPEND_WOL;
next prev parent reply other threads:[~2005-05-24 0:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-23 23:53 [PATCH 0/6] bnx2: Misc fixes Michael Chan
2005-05-24 0:25 ` [PATCH 1/6] bnx2: Fix excessive stack usage Michael Chan
2005-05-24 1:42 ` Jeff Garzik
2005-05-24 4:29 ` Michael Chan
2005-05-24 5:43 ` Jeff Garzik
2005-05-25 22:18 ` David S. Miller
2005-05-24 0:26 ` [PATCH 2/6] bnx2: Fix rx checksum Michael Chan
2005-05-24 0:27 ` [PATCH 3/6] bnx2: Fix excessive udelay Michael Chan
2005-05-24 0:29 ` Michael Chan [this message]
2005-05-24 0:29 ` [PATCH 5/6] bnx2: Add bnx2 prefix and mark static Michael Chan
2005-05-24 0:30 ` [PATCH 6/6] bnx2: Update revision and reldate Michael Chan
2005-05-24 1:48 ` [PATCH 0/6] bnx2: Misc fixes Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1116894543.4908.32.camel@rh4 \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).