netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Paris <eparis@parisplace.org>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@oss.sgi.com, jgarzik@pobox.com,
	bonding-devel@lists.sourceforge.net
Subject: Re: [PATCH] bonding using arp_ip_target may stay down with active path
Date: Tue, 24 May 2005 14:31:02 -0400	[thread overview]
Message-ID: <1116959462.8954.6.camel@localhost.localdomain> (raw)
In-Reply-To: <1116959200.8954.5.camel@localhost.localdomain>

It ate my tabs again.  This mailer is going out the window.

-Eric

On Tue, 2005-05-24 at 14:26 -0400, Eric Paris wrote:
> >On Mon, 2005-05-23 at 14:21 -0700, Jay Vosburgh wrote:
> David S. Miller <davem@davemloft.net> wrote:
> >Patch doesn't apply, tabs turned into spaces by your
> >email client.
> >
> >	As penance for test applying trivial patches by hand, here's a
> >proper version.
> >
> >	-J
> >
> >---
> >	-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
> 
> I guess I should be in the signed off list as the original author.
> sorry I'm an idiot and copied and pasted my original message (to the
> bonding-devel list) which screwed up the spacing.
> 
> Signed-off-by: Eric Paris <eparis@parisplace.org>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
> 
> diff -urN linux-2.6.11/drivers/net/bonding/bond_main.c linux-2.6.11-fix/drivers/net/bonding/bond_main.c
> --- linux-2.6.11/drivers/net/bonding/bond_main.c	2005-05-23 14:07:37.000000000 -0700
> +++ linux-2.6.11-fix/drivers/net/bonding/bond_main.c	2005-05-23 14:08:13.000000000 -0700
> @@ -3046,7 +3046,7 @@
>  			bond_set_slave_inactive_flags(bond->current_arp_slave);
>  
>  			/* search for next candidate */
> -			bond_for_each_slave_from(bond, slave, i, bond->current_arp_slave) {
> +			bond_for_each_slave_from(bond, slave, i, bond->current_arp_slave->next) {
>  				if (IS_UP(slave->dev)) {
>  					slave->link = BOND_LINK_BACK;
>  					bond_set_slave_active_flags(slave);
> 

  reply	other threads:[~2005-05-24 18:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-16 18:41 [PATCH] bonding using arp_ip_target may stay down with active path Eric Paris
2005-05-16 20:34 ` Jay Vosburgh
2005-05-23 19:51   ` David S. Miller
2005-05-23 21:21     ` Jay Vosburgh
2005-05-24 18:26       ` Eric Paris
2005-05-24 18:31         ` Eric Paris [this message]
2005-05-25  0:37           ` David S. Miller
2005-05-25 22:21       ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1116959462.8954.6.camel@localhost.localdomain \
    --to=eparis@parisplace.org \
    --cc=bonding-devel@lists.sourceforge.net \
    --cc=davem@davemloft.net \
    --cc=fubar@us.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).