From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Paris Subject: Re: [PATCH] bonding using arp_ip_target may stay down with active path Date: Tue, 24 May 2005 14:31:02 -0400 Message-ID: <1116959462.8954.6.camel@localhost.localdomain> References: <200505232121.j4NLLaYa000837@death.nxdomain.ibm.com> <1116959200.8954.5.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , netdev@oss.sgi.com, jgarzik@pobox.com, bonding-devel@lists.sourceforge.net Return-path: To: Jay Vosburgh In-Reply-To: <1116959200.8954.5.camel@localhost.localdomain> Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org It ate my tabs again. This mailer is going out the window. -Eric On Tue, 2005-05-24 at 14:26 -0400, Eric Paris wrote: > >On Mon, 2005-05-23 at 14:21 -0700, Jay Vosburgh wrote: > David S. Miller wrote: > >Patch doesn't apply, tabs turned into spaces by your > >email client. > > > > As penance for test applying trivial patches by hand, here's a > >proper version. > > > > -J > > > >--- > > -Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com > > I guess I should be in the signed off list as the original author. > sorry I'm an idiot and copied and pasted my original message (to the > bonding-devel list) which screwed up the spacing. > > Signed-off-by: Eric Paris > Signed-off-by: Jay Vosburgh > > diff -urN linux-2.6.11/drivers/net/bonding/bond_main.c linux-2.6.11-fix/drivers/net/bonding/bond_main.c > --- linux-2.6.11/drivers/net/bonding/bond_main.c 2005-05-23 14:07:37.000000000 -0700 > +++ linux-2.6.11-fix/drivers/net/bonding/bond_main.c 2005-05-23 14:08:13.000000000 -0700 > @@ -3046,7 +3046,7 @@ > bond_set_slave_inactive_flags(bond->current_arp_slave); > > /* search for next candidate */ > - bond_for_each_slave_from(bond, slave, i, bond->current_arp_slave) { > + bond_for_each_slave_from(bond, slave, i, bond->current_arp_slave->next) { > if (IS_UP(slave->dev)) { > slave->link = BOND_LINK_BACK; > bond_set_slave_active_flags(slave); >