From: jamal <hadi@cyberus.ca>
To: Thomas Graf <tgraf@suug.ch>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@oss.sgi.com
Subject: Re: PATCH: rtnetlink explicit flags setting
Date: Fri, 27 May 2005 11:01:31 -0400 [thread overview]
Message-ID: <1117206091.6383.73.camel@localhost.localdomain> (raw)
In-Reply-To: <20050527141320.GQ15391@postel.suug.ch>
On Fri, 2005-27-05 at 16:13 +0200, Thomas Graf wrote:
> That is what the patch does but the diff looks a bit irritating.
> 1) Introduce NLMSG_NEW to take flags
> 2) Make NLMSG_PUT call NLMSG_NEW with flags==0
> 3) Change __nlmsg_put to take flags argument
>
Yikes - sorry i glossed over the patch.
> > The first change would be definetely on top of the current patch i sent
> > which is well deserved.
> > Lets have Dave swallow my patch then either you or i could make those
> > changes. Sounds reasonable?
>
> Sure.
Dave please apply the patch i posted into your tree and then we can
follow with this other stuff.
Actually Thomas, you can probably apply my patch on your side and then
the other changes to use _NEW() on top of it. If you dont have time i
could do it tommorow.
cheers,
jamal
next prev parent reply other threads:[~2005-05-27 15:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-27 12:32 PATCH: rtnetlink explicit flags setting jamal
2005-05-27 12:50 ` Thomas Graf
2005-05-27 13:58 ` jamal
2005-05-27 14:13 ` Thomas Graf
2005-05-27 15:01 ` jamal [this message]
2005-05-27 15:19 ` Thomas Graf
2005-05-27 15:57 ` jamal
2005-05-27 16:59 ` Thomas Graf
2005-05-27 17:00 ` [PATCH 1/2] [NETLINK] Introduce NLMSG_NEW macro to better handle netlink flags Thomas Graf
2005-05-27 17:01 ` [PATCH 2/2] [NETLINK] Correctly set NLM_F_MULTI without checking the pid Thomas Graf
2005-05-28 1:06 ` jamal
2005-05-31 22:37 ` David S. Miller
2005-05-28 1:12 ` PATCH: rtnetlink explicit flags setting jamal
2005-05-28 1:28 ` Thomas Graf
2005-05-28 1:48 ` jamal
2005-05-28 12:18 ` Thomas Graf
2005-05-28 16:00 ` jamal
2005-05-28 16:16 ` Thomas Graf
2005-05-31 9:39 ` jamal
2005-05-31 9:41 ` who 王海
2005-05-31 21:43 ` PATCH: rtnetlink explicit flags setting David S. Miller
2005-05-31 22:26 ` Thomas Graf
2005-05-31 22:31 ` David S. Miller
2005-06-02 13:04 ` PATCH: explicit typing WAS(Re: " jamal
2005-06-02 13:30 ` jamal
2005-06-03 5:08 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1117206091.6383.73.camel@localhost.localdomain \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).