From: Greg Banks <gnb@melbourne.sgi.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Linux Network Development list <netdev@oss.sgi.com>, mchan@broadcom.com
Subject: Re: [PATCH]: Tigon3 new NAPI locking v2
Date: Tue, 07 Jun 2005 20:11:12 +1000 [thread overview]
Message-ID: <1118139072.2198.119.camel@hole.melbourne.sgi.com> (raw)
In-Reply-To: <20050603.122558.88474819.davem@davemloft.net>
On Sat, 2005-06-04 at 05:25, David S. Miller wrote:
> This version incorporates two bug fixes from Michael.
>
> 1) Check the mailbox register for 0x1 while polling on the COMPLETE
> state bit.
>
> 2) Remove the BUG_ON() check in tg3_restart_ints(), it can legally and
> harmlessly occur.
>
> Point #2 may want some refinements, but this patch below is good
> enough for testing.
This patch seems to run well, so far without the lockup we saw
with the first version. It really helps with irq fairness when
we have lots of tg3 and Fibre Channel HBA interrupts going to the
same CPU.
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
next prev parent reply other threads:[~2005-06-07 10:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-03 19:25 [PATCH]: Tigon3 new NAPI locking v2 David S. Miller
2005-06-03 20:23 ` Jeff Garzik
2005-06-06 6:01 ` David S. Miller
2005-06-07 10:11 ` Greg Banks [this message]
2005-06-21 20:21 ` David S. Miller
2005-06-16 11:37 ` Herbert Xu
2005-06-16 11:59 ` Herbert Xu
2005-06-16 13:04 ` Herbert Xu
2005-06-16 20:04 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1118139072.2198.119.camel@hole.melbourne.sgi.com \
--to=gnb@melbourne.sgi.com \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).