Netdev List
 help / color / mirror / Atom feed
From: Maxime Bizon <mbizon@freebox.fr>
To: netdev@oss.sgi.com
Subject: [PATCH] ipconfig.c: fix dhcp timeout behaviour
Date: Fri, 24 Jun 2005 20:53:09 +0200	[thread overview]
Message-ID: <1119639189.14765.154.camel@sakura.staff.proxad.net> (raw)

Hello,

I think there is a small bug in ipconfig.c in case IPCONFIG_DHCP is set
and dhcp is used.

When a DHCPOFFER is received, ip address is kept until we get DHCPACK.
If no ack is received, ic_dynamic() returns negatively, but leaves the
offered ip address in ic_myaddr.

This makes the main loop in ip_auto_config() break and uses the maybe
incomplete configuration.

Not sure if it's the best way to do, but the following trivial patch
correct this. 


Signed-off-by: Maxime Bizon <mbizon@freebox.fr>

--- linux-2.6.12.1/net/ipv4/ipconfig.c.orig	2005-06-22 21:33:05.000000000 +0200
+++ linux-2.6.12.1/net/ipv4/ipconfig.c	2005-06-24 17:55:11.000000000 +0200
@@ -1149,8 +1149,10 @@ static int __init ic_dynamic(void)
 		ic_rarp_cleanup();
 #endif
 
-	if (!ic_got_reply)
+	if (!ic_got_reply) {
+		ic_myaddr = INADDR_NONE;
 		return -1;
+	}
 
 	printk("IP-Config: Got %s answer from %u.%u.%u.%u, ",
 		((ic_got_reply & IC_RARP) ? "RARP" 


-- 
Maxime

                 reply	other threads:[~2005-06-24 18:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1119639189.14765.154.camel@sakura.staff.proxad.net \
    --to=mbizon@freebox.fr \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox