netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Harald Welte <laforge@netfilter.org>
Cc: netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org,
	wensong@linux-vs.org
Subject: Re: [PATCH] reduce netfilte sk_buff enlargement
Date: Thu, 21 Jul 2005 20:20:35 +0200	[thread overview]
Message-ID: <1121970035.5904.6.camel@notepaq> (raw)
In-Reply-To: <20050720132305.GA4077@rama>

Hi Harald,

> I just ran into Marcel Holtmann earlier today.  He thinks moving that
> data into the cb is fine, though he has to double-check that.
> 
> He also said that he really only needs 5 bits, so even if the current
> pkt_type overloading would persist, we could probably shrink it to make
> space for the IPVS bit.

please forget about the 5 bits thingy, I told you. Splitting it up into
bitlevel will screw up the HCI filter completly. However after a look
trough the Bluetooth core it should be quite easy too move the pkt_type
into the control buffer. We already use it for a direction bit. The
nasty thing is that I have to modify all the drivers. So when you
finally decided to shrink the pkt_type, I think that I can come up with
a patch for it quiet quickly.

Regards

Marcel

  parent reply	other threads:[~2005-07-21 18:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-16 21:40 [PATCH] reduce netfilte sk_buff enlargement Harald Welte
2005-07-19  3:31 ` David S. Miller
2005-07-19  7:18   ` Jan Engelhardt
2005-07-19  7:23     ` David S. Miller
2005-07-20 13:23   ` Harald Welte
2005-07-20 15:43     ` Wensong Zhang
2005-07-20 21:35       ` Patrick McHardy
2005-07-20 18:43     ` David S. Miller
2005-07-21 18:20     ` Marcel Holtmann [this message]
2005-07-21 20:12       ` David S. Miller
2005-07-21 21:42         ` Marcel Holtmann
2005-07-21 22:10           ` David S. Miller
2005-07-21 22:29           ` David S. Miller
2005-07-21 23:49             ` Marcel Holtmann
2005-07-21 23:52               ` David S. Miller
2005-07-22  0:26                 ` Marcel Holtmann
2005-07-22 22:54                   ` David S. Miller
2005-07-23  1:36                     ` Marcel Holtmann
2005-07-25  2:18                       ` David S. Miller
2005-07-22  8:34             ` Amin Azez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1121970035.5904.6.camel@notepaq \
    --to=marcel@holtmann.org \
    --cc=laforge@netfilter.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=wensong@linux-vs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).