From: Jay Vosburgh <fubar@us.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: Andy Gospodarek <andy@greyhouse.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] bonding: reduce noise during init
Date: Tue, 26 Jul 2011 17:37:19 -0700 [thread overview]
Message-ID: <11239.1311727039@death> (raw)
In-Reply-To: <1311717286.15386.34.camel@Joe-Laptop>
Joe Perches <joe@perches.com> wrote:
>On Tue, 2011-07-26 at 17:35 -0400, Andy Gospodarek wrote:
>> Many are using sysfs to configure bonding rather than module options, so
>> there is no need for bonding to throw this warning in normal cases.
>> Keep the message around when debugging is enabled as it might be useful
>> for someone desperate enough to enable debugging, but eliminate it
>> otherwise.
>[]
>> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>[]
>> @@ -4745,7 +4745,10 @@ static int bond_check_params(struct bond_params *params)
>> /* miimon and arp_interval not set, we need one so things
>> * work as expected, see bonding.txt for details
>> */
>> - pr_warning("Warning: either miimon or arp_interval and arp_ip_target module parameters must be specified, otherwise bonding will not detect link failures! see bonding.txt for details.\n");
>> + pr_debug("Warning: either miimon or arp_interval and"
>> + " arp_ip_target module parameters must be specified,"
>> + " otherwise bonding will not detect link failures!"
>> + " See bonding.txt for details.\n");
>
>I'd prefer you don't separate the format string
>into multiple pieces.
Why not? To me, it looks easier to read split into sections
that don't wrap lines.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2011-07-27 0:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 21:35 [PATCH net-next-2.6] bonding: reduce noise during init Andy Gospodarek
2011-07-26 21:54 ` Joe Perches
2011-07-27 0:37 ` Jay Vosburgh [this message]
2011-07-27 0:40 ` Joe Perches
2011-07-27 1:05 ` Andy Gospodarek
[not found] ` <CAHashqDd8iFou7MsdCU2=2mEyaSo5RvsJoqd47jZTCwwdU81eA@mail.gmail.com>
2011-07-27 1:08 ` Joe Perches
2011-07-27 20:09 ` [PATCH net-next-2.6 v2] " Andy Gospodarek
2011-07-28 5:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11239.1311727039@death \
--to=fubar@us.ibm.com \
--cc=andy@greyhouse.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).