From: Pavel Roskin <proski-mXXj517/zsQ@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Orinoco Development List
<orinoco-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 8/8] orinoco: New driver - spectrum_cs.
Date: Fri, 09 Sep 2005 18:40:09 -0400 [thread overview]
Message-ID: <1126305609.16679.1.camel@dv> (raw)
In-Reply-To: <20050906112424.GA5309-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
On Tue, 2005-09-06 at 12:24 +0100, Christoph Hellwig wrote:
> > +#ifdef __IN_PCMCIA_PACKAGE__
> > +#include <pcmcia/k_compat.h>
> > +#endif /* __IN_PCMCIA_PACKAGE__ */
>
> this doesn't make sense for a 2.6 driver.
Fixed in my tree, thanks. Patches will be sent shortly.
> > +#ifdef SPECTRUM_FW_INCLUDED
> > +/* Header with the firmware */
> > +#include "spectrum_fw.h"
> > +#else /* !SPECTRUM_FW_INCLUDED */
>
> While I see the point of this for the standalone orinoco driver package
> it doesn't make sense for the version in the kernel tree.
Likewise.
>
> > +#define CS_CHECK(fn, ret) \
> > + do { last_fn = (fn); if ((last_ret = (ret)) != 0) goto cs_failed; } while (0)
>
> I don't think this macro abuse helps anyone..
Sure, but it's abused by many drivers. Maybe next time.
--
Regards,
Pavel Roskin
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
prev parent reply other threads:[~2005-09-09 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-02 0:10 [PATCH 8/8] orinoco: New driver - spectrum_cs Pavel Roskin
2005-09-06 11:24 ` Christoph Hellwig
[not found] ` <20050906112424.GA5309-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2005-09-09 22:40 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1126305609.16679.1.camel@dv \
--to=proski-mxxj517/zsq@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=orinoco-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).