From: Marcel Holtmann <marcel@holtmann.org>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Arnaldo Carvalho de Melo <acme@conectiva.com.br>,
Ralf Baechle <ralf@linux-mips.org>,
Greg Kroah-Hartman <greg@kroah.com>,
dccp@vger.kernel.org, Patrick Caulfield <patrick@tykepenguin.com>,
Jean Tourrilhes <jt@hpl.hp.com>,
Sridhar Samudrala <sri@us.ibm.com>,
Andy Adamson <andros@umich.edu>,
"J. Bruce Fields" <bfields@umich.edu>,
Nenad Corbic <ncorbic@sangoma.com>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Subject: Re: [PATCH 01/14] Big kfree NULL check cleanup - net
Date: Fri, 14 Oct 2005 11:50:50 +0200 [thread overview]
Message-ID: <1129283450.5057.29.camel@localhost.localdomain> (raw)
In-Reply-To: <200510132125.44470.jesper.juhl@gmail.com>
Hi Jesper,
> This is the net/ part of the big kfree cleanup patch.
>
> Remove pointless checks for NULL prior to calling kfree() in net/.
>
>
> Sorry about the long Cc: list, but I wanted to make sure I included everyone
> who's code I've changed with this patch.
you forgot me ;)
> --- linux-2.6.14-rc4-orig/net/bluetooth/hidp/core.c 2005-08-29 01:41:01.000000000 +0200
> +++ linux-2.6.14-rc4/net/bluetooth/hidp/core.c 2005-10-13 11:47:49.000000000 +0200
> @@ -657,9 +657,7 @@ unlink:
> failed:
> up_write(&hidp_session_sem);
>
> - if (session->input)
> - kfree(session->input);
> -
> + kfree(session->input);
> kfree(session);
> return err;
> }
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2005-10-14 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-13 19:25 [PATCH 01/14] Big kfree NULL check cleanup - net Jesper Juhl
2005-10-14 9:50 ` Marcel Holtmann [this message]
2005-10-14 12:02 ` Jesper Juhl
2005-10-14 12:51 ` YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1129283450.5057.29.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=acme@conectiva.com.br \
--cc=akpm@osdl.org \
--cc=andros@umich.edu \
--cc=bfields@umich.edu \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=greg@kroah.com \
--cc=jesper.juhl@gmail.com \
--cc=jt@hpl.hp.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=ncorbic@sangoma.com \
--cc=netdev@vger.kernel.org \
--cc=patrick@tykepenguin.com \
--cc=ralf@linux-mips.org \
--cc=sri@us.ibm.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox