From: Maxime Bizon <mbizon@freebox.fr>
To: davem@davemloft.net
Cc: netdev@oss.sgi.com
Subject: [PATCH] ipconfig.c: fix dhcp timeout leading to bad requested address.
Date: Wed, 19 Oct 2005 21:43:32 +0200 [thread overview]
Message-ID: <1129751012.1724.13.camel@sakura.staff.proxad.net> (raw)
Hello,
There is still a little bug in dhcp timeout handling.
When DHCPOFFER is received, offered and server addresses are kept. If no
ack is received, ic_myaddr is reset to INADDR_NONE, but not ic_servaddr.
The problem is that ic_dhcp_init_options() checks only ic_servaddr to
known if it has to send a DHCPOFFER or a DHCPREQUEST. So packets sent
after a timeout will be DHCPREQUEST with requested address INADDR_NONE.
If the the dhcp server does not NAK it, this request is done forever.
The following patch fixes this.
Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
--- linux-2.6.13.4/net/ipv4/ipconfig.c.orig 2005-10-18 18:11:54.000000000 +0200
+++ linux-2.6.13.4/net/ipv4/ipconfig.c 2005-10-19 20:44:07.000000000 +0200
@@ -1151,6 +1151,7 @@
if (!ic_got_reply) {
ic_myaddr = INADDR_NONE;
+ ic_servaddr = INADDR_NONE;
return -1;
}
--
Maxime
reply other threads:[~2005-10-19 19:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1129751012.1724.13.camel@sakura.staff.proxad.net \
--to=mbizon@freebox.fr \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox