From: Paolo Abeni <pabeni@redhat.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
netdev@vger.kernel.org
Cc: davem@davemloft.net, Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next v2 1/2] udp: msg_zerocopy
Date: Mon, 26 Nov 2018 17:32:19 +0100 [thread overview]
Message-ID: <11350ff03fc6b03e34f8b4acd063371c887758d8.camel@redhat.com> (raw)
In-Reply-To: <20181126152939.258443-2-willemdebruijn.kernel@gmail.com>
Hi,
Sorry for the long delay...
On Mon, 2018-11-26 at 10:29 -0500, Willem de Bruijn wrote:
> @@ -1109,6 +1128,7 @@ static int __ip_append_data(struct sock *sk,
> error_efault:
> err = -EFAULT;
> error:
> + sock_zerocopy_put_abort(uarg);
> cork->length -= length;
> IP_INC_STATS(sock_net(sk), IPSTATS_MIB_OUTDISCARDS);
> refcount_add(wmem_alloc_delta, &sk->sk_wmem_alloc);
Out of sheer ignorance on my side, don't we have a bad reference
accounting if e.g.:
- uarg is attached to multiple skbs, each holding a ref,
- there is a failure on 'getfrag()'
Such failure will release 2 references (1 kfree_skb(), and another in
the above sock_zerocopy_put_abort(), as the count is still positive).
Cheers,
Paolo
next prev parent reply other threads:[~2018-11-27 3:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 15:29 [PATCH net-next v2 0/2] udp msg_zerocopy Willem de Bruijn
2018-11-26 15:29 ` [PATCH net-next v2 1/2] udp: msg_zerocopy Willem de Bruijn
2018-11-26 16:32 ` Paolo Abeni [this message]
2018-11-26 17:59 ` Willem de Bruijn
2018-11-26 18:04 ` Paolo Abeni
2018-11-26 18:19 ` Willem de Bruijn
2018-11-26 19:49 ` Willem de Bruijn
2018-11-28 23:50 ` Willem de Bruijn
2018-11-29 8:27 ` Paolo Abeni
2018-11-29 16:17 ` Willem de Bruijn
2018-11-29 7:31 ` [udp] a4a142d3d7: WARNING:at_lib/refcount.c:#refcount_inc_checked kernel test robot
2018-11-26 15:29 ` [PATCH net-next v2 2/2] selftests: extend zerocopy tests to udp Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11350ff03fc6b03e34f8b4acd063371c887758d8.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).