From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Vlasenko <vda@ilport.com.ua>
Cc: "John W. Linville" <linville@tuxdriver.com>,
jbenc@suse.cz, netdev@vger.kernel.org,
softmac-dev@sipsolutions.net, linux-kernel@vger.kernel.org,
bcm43xx-dev@lists.berlios.de
Subject: Re: [softmac-dev] [PATCH] ieee80211_rx_any: filter out packets, call ieee80211_rx or ieee80211_rx_mgt
Date: Mon, 23 Jan 2006 15:32:32 +0100 [thread overview]
Message-ID: <1138026752.3957.98.camel@localhost> (raw)
In-Reply-To: <200601221404.52757.vda@ilport.com.ua>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
On Sun, 2006-01-22 at 14:04 +0200, Denis Vlasenko wrote:
> + hdr = (struct ieee80211_hdr_4addr *)skb->data;:
> + fc = le16_to_cpu(hdr->frame_ctl);:
> +:
> + switch (fc & IEEE80211_FCTL_FTYPE) {:
> + case IEEE80211_FTYPE_MGMT:
> + ieee80211_rx_mgt(ieee, hdr, stats);:
> + return 0;:
Shouldn't you BSS-filter management packets too?
> + is_packet_for_us = 0;:
> + switch (ieee->iw_mode) {:
> + case IW_MODE_ADHOC:
> + /* promisc: get all */
> + if (ieee->dev->flags & IFF_PROMISC):
> + is_packet_for_us = 1;
And I still think BSS-filtering is correct even in the promisc case. Any
other opinions why either way is right or not? [I think we should filter
because upper layers won't know the packet wasn't for us if it was
broadcast in another BSSID]
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2006-01-23 14:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-18 20:06 wireless: the contenders John W. Linville
2006-01-18 20:19 ` [Bcm43xx-dev] " Michael Buesch
2006-01-18 20:25 ` John W. Linville
2006-01-18 20:36 ` Jeff Garzik
2006-01-18 20:48 ` John W. Linville
2006-01-18 20:52 ` Jeff Garzik
2006-01-19 0:19 ` [Bcm43xx-dev] " Johannes Berg
2006-01-19 15:27 ` John W. Linville
2006-01-22 11:57 ` [PATCH] trivial fix Denis Vlasenko
2006-01-22 11:59 ` [PATCH] ieee80211_rx_any: filter out packets, call ieee80211_rx or ieee80211_rx_mgt Denis Vlasenko
[not found] ` <200601221359.31482.vda-BN/BzeNzsW2SlH3FCl+8hg@public.gmane.org>
2006-01-22 12:08 ` Denis Vlasenko
2006-01-22 12:25 ` [Bcm43xx-dev] " Michael Buesch
2006-01-22 12:04 ` Denis Vlasenko
2006-01-22 13:32 ` Patrick McHardy
2006-01-23 14:32 ` Johannes Berg [this message]
2006-01-23 19:00 ` [softmac-dev] " Stefan Rompf
2006-01-24 8:06 ` [Bcm43xx-dev] " Denis Vlasenko
2006-01-25 15:44 ` Stuffed Crust
2006-01-26 10:25 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1138026752.3957.98.camel@localhost \
--to=johannes@sipsolutions.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=jbenc@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=softmac-dev@sipsolutions.net \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).