From: "Michael Chan" <mchan@broadcom.com>
To: "Jeff Mahoney" <jeffm@suse.com>
Cc: "Andrew Morton" <akpm@osdl.org>,
"Linus Torvalds" <torvalds@osdl.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Jeff Garzik" <jgarzik@pobox.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] tg3: netif_carrier_off runs too early; could still be queued when init fails
Date: Tue, 21 Feb 2006 08:44:20 -0800 [thread overview]
Message-ID: <1140540260.20584.6.camel@rh4> (raw)
In-Reply-To: <20060220194337.GA21719@locomotive.unixthugs.org>
On Mon, 2006-02-20 at 14:43 -0500, Jeff Mahoney wrote:
> This patch moves the netif_carrier_off() call from tg3_init_one()->
> tg3_init_link_config() to tg3_open() as is the convention for most
> other network drivers.
I think moving netif_carrier_off() later is the right thing to do. We
can also move it to the end of tg3_init_one() just before returning 0.
>
> I was getting a panic after a tg3 device failed to initialize due to DMA
> failure. The oops pointed to the link watch queue with spinlock debugging
> enabled. Without spinlock debugging, the Oops didn't occur.
>
> I suspect that the link event was getting queued but not executed until
> after the DMA test had failed and the device was freed. The link event
> was then operating on freed memory, which could contain anything. With this
> patch applied, the Oops no longer occurs.
DMA test failed? What NIC device do you have? How did it fail?
Thanks.
next parent reply other threads:[~2006-02-21 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060220194337.GA21719@locomotive.unixthugs.org>
2006-02-21 16:44 ` Michael Chan [this message]
2006-02-21 21:39 ` [PATCH] tg3: netif_carrier_off runs too early; could still be queued when init fails David S. Miller
2006-02-21 22:41 ` Jeff Mahoney
2006-02-21 21:57 ` Michael Chan
2006-02-22 0:35 ` David S. Miller
2006-02-22 16:48 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1140540260.20584.6.camel@rh4 \
--to=mchan@broadcom.com \
--cc=akpm@osdl.org \
--cc=jeffm@suse.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).