From: Carlos Martin <carlos@cmartin.tk>
To: netdev@vger.kernel.org
Cc: Denis Vlasenko <vda@ilport.com.ua>,
acx100-devel@lists.sourceforge.net,
Christoph Hellwig <hch@infradead.org>
Subject: [PATCH 0/7] acxsm: Make acxsm modular again (2nd try)
Date: Tue, 28 Feb 2006 17:30:13 +0100 [thread overview]
Message-ID: <1141144213577-git-send-email-carlos@cmartin.tk> (raw)
In-Reply-To:
Hi,
There are a couple of differences between this and my previos patch,
so I'll list them here:
- Separate the patches properly
- This patchset uses the default generic functions and calls the
appropiate function using a #define, which should be much clearer
and saves us from having to migrate the whole common.c file.
- We get the proper string for the _debug family of functions.
- acx_ops.issue_cmd takes different functions depending on the debug
level so we save a few bytes we weren't going to use otherwise. This
also saves a function call.
- Denis' sense of style has been applied, though some of it doesn't
apply anymore and some came from me trying to do too many things at
once which screwed up the format. I hope these are alright.
Kconfig | 40 ++++++++++----------
Makefile | 15 +++++--
acx_func.h | 112 ++++++++++++++++++++--------------------------------------
acx_struct.h | 32 ++++++++++++++--
common.c | 113 ++++++++++++++++++++++++++++-------------------------------
ioctl.c | 2 +
pci.c | 31 ++++++++++++++++
usb.c | 27 +++++++++++++-
8 files changed, 212 insertions(+), 160 deletions(-)
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x110944&bid$1720&dat\x121642
next reply other threads:[~2006-02-28 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-28 16:30 Carlos Martin [this message]
2006-02-28 16:30 ` [PATCH 1/7] acxsm: Change Kconfig and Makefile to be modular Carlos Martin
2006-02-28 16:30 ` [PATCH 2/7] acxsm: Move module init/exit to the modules Carlos Martin
2006-02-28 16:30 ` [PATCH 6/7] acxsm: Assign chip-specific ops in the probe functions Carlos Martin
2006-02-28 16:30 ` [PATCH 3/7] acxsm: Create struct acx_ops Carlos Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1141144213577-git-send-email-carlos@cmartin.tk \
--to=carlos@cmartin.tk \
--cc=acx100-devel@lists.sourceforge.net \
--cc=hch@infradead.org \
--cc=netdev@vger.kernel.org \
--cc=vda@ilport.com.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).