From: a1 <a1k@mail.ru>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: netdev@vger.kernel.org
Subject: Re: e1000 speed/duplex error
Date: Thu, 3 Aug 2006 11:51:18 +0400 [thread overview]
Message-ID: <1141838417.20060803115118@mail.ru> (raw)
In-Reply-To: <44D0BE71.9080205@intel.com>
Hi, Auke.
Auke Kok wrote:
AK> Don't you mean this? :
AK> + hw->autoneg_advertised = ecmd->advertising |
AK> + ADVERTISED_Autoneg |
AK> + ADVERTISED_TP;
AK> and we'd also have to do this for fibre...
Yep. I've noticed that but I already sent message...
>>
>> ecmd->advertising = hw->autoneg_advertised;
>> } else
>> if (e1000_set_spd_dplx(adapter, ecmd->speed + ecmd->duplex))
AK> but that's not really what you want: the way ethtool works currently only
AK> allows you to pass *one* speed/duplex tuple and autonegotiate with that, or
AK> all (by omitting any speed/duplex tuple).
AK> ethtool needs some code that allows you to specify "autonegotiate 10_half or
AK> 100_full or 1000_full" (3 tuples, but not implying 100_half or 10_full). This
AK> is something mii-tool was able to do but this functionality never made it into
AK> ethtool AFAIK :)
AK> This is the most useful case for everyone, you can omit advertising gig link
AK> if you only have 100mbit switches and speed up link times that way etc.
I'm sure of that, but today before actual ethtool patch released will
this changes be included in the driver sources? In that case IMO no other
changes need to be done to support what you've been writing of...
AK> Auke
--
Best regards,
Alexandr Kotov mailto:a1k@mail.ru
next prev parent reply other threads:[~2006-08-03 7:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 10:18 e1000 speed/duplex error a1
2006-08-01 11:20 ` Jeff Kirsher
2006-08-01 12:03 ` Re[2]: " a1
2006-08-01 12:21 ` Andy Gospodarek
2006-08-01 12:22 ` Re[2]: " Jamal Hadi Salim
2006-08-01 17:03 ` Rick Jones
[not found] ` <793732866.20060801153230@mail.ru>
[not found] ` <9929d2390608010445w4fd81b64g310ae90a423e1a7d@mail.gmail.com>
2006-08-01 12:20 ` Re[4]: " a1
2006-08-01 12:34 ` Jeff Kirsher
2006-08-01 14:35 ` Auke Kok
2006-08-01 17:15 ` Jeff Kirsher
2006-08-02 7:34 ` a1
2006-08-02 7:43 ` Jeff Kirsher
2006-08-02 8:39 ` a1
2006-08-02 15:02 ` Auke Kok
2006-08-03 7:51 ` a1 [this message]
2006-08-02 16:19 ` Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1141838417.20060803115118@mail.ru \
--to=a1k@mail.ru \
--cc=auke-jan.h.kok@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).