From: jamal <hadi@cyberus.ca>
To: balbir@in.ibm.com
Cc: Matt Helsley <matthltc@us.ibm.com>,
Shailabh Nagar <nagar@watson.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting
Date: Fri, 24 Mar 2006 09:19:42 -0500 [thread overview]
Message-ID: <1143209982.5076.24.camel@jzny2> (raw)
In-Reply-To: <1143209518.5076.21.camel@jzny2>
On Fri, 2006-24-03 at 09:11 -0500, jamal wrote:
> Look at using proper macros instead of hard coding like you did.
> grep for something like RTA_SPACE and perhaps send a patch to make it
> generic for netlink.h
>
actually Thomas already has this in netlink.h
Look at using things like:
nla_attr_size()
make sure padding is taken care of etc (read: use the right macros).
cheers,
jamal
next prev parent reply other threads:[~2006-03-24 14:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1142296834.5858.3.camel@elinux04.optonline.net>
2006-03-14 0:55 ` [Patch 8/9] generic netlink utility functions Shailabh Nagar
2006-03-26 16:44 ` Balbir Singh
2006-03-26 17:06 ` jamal
2006-03-14 0:56 ` [Patch 9/9] Generic netlink interface for delay accounting Shailabh Nagar
2006-03-14 2:29 ` jamal
2006-03-14 2:33 ` Matt Helsley
2006-03-14 2:48 ` jamal
2006-03-14 4:18 ` Shailabh Nagar
2006-03-22 7:49 ` [RFC][UPDATED PATCH 2.6.16] " Balbir Singh
2006-03-23 14:04 ` jamal
2006-03-23 15:41 ` Balbir Singh
2006-03-24 14:04 ` jamal
2006-03-24 14:54 ` Balbir Singh
2006-03-25 1:19 ` jamal
2006-03-25 9:41 ` Balbir Singh
2006-03-25 12:52 ` jamal
2006-03-25 15:36 ` Balbir Singh
2006-03-25 17:48 ` jamal
2006-03-25 18:22 ` Balbir Singh
2006-03-26 14:05 ` jamal
2006-03-26 16:40 ` Balbir Singh
2006-03-24 1:32 ` Balbir Singh
2006-03-24 14:11 ` jamal
2006-03-24 14:19 ` jamal [this message]
2006-03-24 14:59 ` Balbir Singh
2006-03-14 4:29 ` Shailabh Nagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1143209982.5076.24.camel@jzny2 \
--to=hadi@cyberus.ca \
--cc=balbir@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=nagar@watson.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).