From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Roskin Subject: Re: [PATCH 16/21] orinoco_pci: disable device and free IRQ when suspending Date: Fri, 07 Apr 2006 18:12:45 -0400 Message-ID: <1144447965.5618.8.camel@dv> References: <20060407081019.16107.67672.stgit@dv.roinet.com> <20060407081051.16107.87289.stgit@dv.roinet.com> <20060407212429.GA15720@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, orinoco-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: To: Francois Romieu In-Reply-To: <20060407212429.GA15720-lmTtMILVy1jWQcoT9B9Ug5SCg42XY1Uw0E9HWUfgJXw@public.gmane.org> Sender: orinoco-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: orinoco-devel-admin-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: List-Id: netdev.vger.kernel.org Hello! On Fri, 2006-04-07 at 23:24 +0200, Francois Romieu wrote: > Pavel Roskin : > [...] > > diff --git a/drivers/net/wireless/orinoco_pci.c b/drivers/net/wireless/orinoco_pci.c > > index 5362c21..e57e92b 100644 > > --- a/drivers/net/wireless/orinoco_pci.c > > +++ b/drivers/net/wireless/orinoco_pci.c > > @@ -304,7 +304,9 @@ static int orinoco_pci_suspend(struct pc > > > > orinoco_unlock(priv, &flags); > > > > + free_irq(pdev->irq, dev); > > pci_save_state(pdev); > > + pci_disable_device(pdev); > > pci_set_power_state(pdev, PCI_D3hot); > > > > return 0; > > /me stares at the thread behind http://lkml.org/lkml/2005/7/30/143 > > Imho {free/request}_irq during suspend/resume deserves some > explanation. I followed examples from other drivers. The thread in question deals with the patch where pci_disable_device() precedes free_irq(). Besides, bridges may need special care because they pass interrupts from other devices. I also followed the kernel documentation (Documentation/power/pci.txt), which says that the driver should free the IRQ on suspend. If you can suggest an alternative approach, please do so. I don't see what I can do differently. -- Regards, Pavel Roskin ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642