bcm43xx symbol clash problems

bcm43xx symbol clash problems

[Michael Buesch]

Hi,

I looked into the symbol clash problems between bcm43xx and bcm43xx-d80211
you mentioned at the wireless summit.
Well, IMHO it is pretty hard to find a good solution to this.
The situation is: We have several nonstatic functions in the bcm driver. These
functions have the same name in the softmac and dscape versions. It's quite a
lot of functions.
We can't make them static, because the driver is splitted over several files.
I would _really_ want to prevent renaming them all, because that is lots of work,
which will be thrown away anyway.
Does kbuild perhaps have some magic to handle that?

This needs to be solved soon, but I have no idea how.

I also wanna note that I am looking into using quilt for bcm43xx development.
git is not the perfect solution for bcm43xx development. Maybe quilt is.
Who knows... Let's try it.

-- 
Greetings Michael, who would like to have the namespace keyword in C.

Re: bcm43xx symbol clash problems

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

On Mon, 2006-04-10 at 02:16 +0200, Michael Buesch wrote:
> Does kbuild perhaps have some magic to handle that?
> 
> This needs to be solved soon, but I have no idea how.

You want to have bcm43xx and bcm43xx-dscape conflict anyway, since
there's no point in building both into the kernel, only one can be bound
to a device. Yes, I know one could still bind them manually, but that's
about as icky as building them as modules imho. And whoever really needs
a static kernel will not need both of them.

I don't know how the Kconfig there is laid out, but wouldn't it be
possible to make them conflict on both yes?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]

Re: bcm43xx symbol clash problems

[Michael Buesch]

On Tuesday 11 April 2006 08:39, Johannes Berg wrote:
> On Mon, 2006-04-10 at 02:16 +0200, Michael Buesch wrote:
> > Does kbuild perhaps have some magic to handle that?
> > 
> > This needs to be solved soon, but I have no idea how.
> 
> You want to have bcm43xx and bcm43xx-dscape conflict anyway, since
> there's no point in building both into the kernel, only one can be bound
> to a device. Yes, I know one could still bind them manually, but that's
> about as icky as building them as modules imho. And whoever really needs
> a static kernel will not need both of them.
> 
> I don't know how the Kconfig there is laid out, but wouldn't it be
> possible to make them conflict on both yes?

Sure. I would probably say that both m should conflict, too.
And one y and the other m, too.
This can be done with ugly "depends" statements.

-- 
Greetings Michael.

Re: bcm43xx symbol clash problems

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

On Tue, 2006-04-11 at 18:35 +0200, Michael Buesch wrote:

> Sure. I would probably say that both m should conflict, too.

Nah, you probably want both m for testing.

> And one y and the other m, too.

Yeah that should conflict too.

> This can be done with ugly "depends" statements.

I have no idea.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]

Re: bcm43xx symbol clash problems

[Michael Buesch]

On Tuesday 11 April 2006 18:42, Johannes Berg wrote:
> On Tue, 2006-04-11 at 18:35 +0200, Michael Buesch wrote:
> 
> > Sure. I would probably say that both m should conflict, too.
> 
> Nah, you probably want both m for testing.

I am OK with this, but it fucks up module autoloading.
But that is probably OK.

-- 
Greetings Michael.