From: Eric Sesterhenn <snakebyte@gmx.de>
To: netdev@vger.kernel.org
Cc: dugsong@monkey.org
Subject: [Patch] Dead code in net/sunrpc/auth_gss/auth_gss.c
Date: Tue, 18 Apr 2006 18:07:11 +0200 [thread overview]
Message-ID: <1145376431.11649.2.camel@localhost> (raw)
Hi,
the coverity checker spotted that cred is always NULL
when we jump to out_err ( there is just one case, when
we fail to allocate the memory for cred )
This is Coverity ID #79
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-rc1/net/sunrpc/auth_gss/auth_gss.c.orig 2006-04-18 13:23:22.000000000 +0200
+++ linux-2.6.17-rc1/net/sunrpc/auth_gss/auth_gss.c 2006-04-18 13:24:10.000000000 +0200
@@ -794,7 +794,6 @@ gss_create_cred(struct rpc_auth *auth, s
out_err:
dprintk("RPC: gss_create_cred failed with error %d\n", err);
- if (cred) gss_destroy_cred(&cred->gc_base);
return ERR_PTR(err);
}
next reply other threads:[~2006-04-18 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 16:07 Eric Sesterhenn [this message]
2006-04-18 16:34 ` [Patch] Dead code in net/sunrpc/auth_gss/auth_gss.c Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145376431.11649.2.camel@localhost \
--to=snakebyte@gmx.de \
--cc=dugsong@monkey.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).