From: Johannes Berg <johannes@sipsolutions.net>
To: Jiri Benc <jbenc@suse.cz>
Cc: Michael Buesch <mb@bu3sch.de>,
"John W. Linville" <linville@tuxdriver.com>,
netdev@vger.kernel.org, bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] bcm43xx-d80211: measure the channel change time
Date: Thu, 04 May 2006 14:22:20 +0200 [thread overview]
Message-ID: <1146745340.1137.26.camel@localhost> (raw)
In-Reply-To: <20060504111140.050c3e2f@griffin.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 573 bytes --]
On Thu, 2006-05-04 at 11:11 +0200, Jiri Benc wrote:
> I think some safety fallback would be better. Like
> if (stop - start < SOME_MIN_VALUE) channel_change_time = SOME_MIN_VALUE
> (of course, this won't work because stop and start are unsigned, but you
> probably got the idea).
Probably. And yes, it should still work since stop>start at all times.
> And couldn't TSF counter overflow during the measurement?
Yes, if the card has been up for like 459148 years or has been reset to
an unbelievably high value. Remember, it's a 64 bit counter.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]
next prev parent reply other threads:[~2006-05-04 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-03 19:05 [PATCH] bcm43xx-d80211: measure the channel change time Michael Buesch
2006-05-04 9:11 ` Jiri Benc
2006-05-04 12:22 ` Johannes Berg [this message]
2006-05-04 12:33 ` Jiri Benc
2006-05-04 12:36 ` Johannes Berg
2006-05-19 18:02 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1146745340.1137.26.camel@localhost \
--to=johannes@sipsolutions.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).