a short look at d80211

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

Hi,

I finally decided to familiarise myself with d80211 a bit more :)

Here are some questions on the code again.

MICHAEL_MIC_HWACCEL seems to be always defined, what is it used for?

IEEE80211_LEDS should probably go away, in fact it should be fairly easy
to register a led trigger driver for each kind of LED and each device.
Then drivers can register a led driver, even with a default led
source... :)

Could ieee80211_msg_* be upper-cased so it's clear right away those are
constants?

Why does IF_TYPE_VLAN exist if according to the comment it isn't used?

bcm43xx doesn't do hardware tsf synchronisation, it provides on each
frame the lower 16 bits of the tsf at the time the frame was received
(no, I don't know if it's at the first bit of the plcp or whatever).
Hence, it'll need to do tsf updates in software whenever necessary.
Could d80211 provide some support for this? Or asking the other way
around, how should it do that?

There's more, especially related to bcm43xx and power saving, but we're
only just beginning to understand how that might work.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 793 bytes --]