* [PATCH 2.6.17 1/2] bnx2: Fix bug in bnx2_nvram_write()
@ 2006-05-22 17:01 Michael Chan
2006-05-22 18:48 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Michael Chan @ 2006-05-22 17:01 UTC (permalink / raw)
To: davem; +Cc: netdev
Fix a bug in bnx2_nvram_write() caused by a counter variable not
correctly incremented by 4.
Signed-off-by: Michael Chan <mchan@broadcom.com>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 5ca99e2..509f104 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -3061,7 +3061,7 @@ bnx2_nvram_write(struct bnx2 *bp, u32 of
}
/* Loop to write the new data from data_start to data_end */
- for (addr = data_start; addr < data_end; addr += 4, i++) {
+ for (addr = data_start; addr < data_end; addr += 4, i += 4) {
if ((addr == page_end - 4) ||
((bp->flash_info->buffered) &&
(addr == data_end - 4))) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.17 1/2] bnx2: Fix bug in bnx2_nvram_write()
2006-05-22 17:01 [PATCH 2.6.17 1/2] bnx2: Fix bug in bnx2_nvram_write() Michael Chan
@ 2006-05-22 18:48 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-05-22 18:48 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev
Michael Chan wrote:
> Fix a bug in bnx2_nvram_write() caused by a counter variable not
> correctly incremented by 4.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
ACK patches 1-2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-05-22 18:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-22 17:01 [PATCH 2.6.17 1/2] bnx2: Fix bug in bnx2_nvram_write() Michael Chan
2006-05-22 18:48 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).