From: Steve Wise <swise@opengridcomputing.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: mshefty@ichips.intel.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, openib-general@openib.org
Subject: Re: [PATCH 2/2] iWARP Core Changes.
Date: Wed, 31 May 2006 15:30:35 -0500 [thread overview]
Message-ID: <1149107435.7469.7.camel@stevo-desktop> (raw)
In-Reply-To: <adaodxeypfd.fsf@cisco.com>
On Wed, 2006-05-31 at 12:17 -0700, Roland Dreier wrote:
> > +EXPORT_SYMBOL(copy_addr);
>
> I think if you want to export this, it needs a less generic name
> (something with an rdma_ prefix probably). Otherwise it's going to
> collide someday...
ok.
The function is needed by the iwcm module, so that's why we exported it.
I could change the name to rdma_copy_addr(), or make the function a
static inline in a header file since its kinda small anyway...
Any preference?
next prev parent reply other threads:[~2006-05-31 20:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-31 18:26 [PATCH 0/2][RFC] iWARP Core Support Steve Wise
2006-05-31 18:26 ` [PATCH 1/2] iWARP Connection Manager Steve Wise
2006-05-31 22:22 ` Sean Hefty
2006-06-01 17:00 ` Steve Wise
2006-06-01 21:09 ` Sean Hefty
2006-06-01 22:21 ` [openib-general] " Tom Tucker
2006-06-01 17:11 ` Tom Tucker
2006-05-31 18:26 ` [PATCH 2/2] iWARP Core Changes Steve Wise
2006-05-31 19:17 ` Roland Dreier
2006-05-31 20:30 ` Steve Wise [this message]
2006-05-31 20:32 ` Roland Dreier
2006-05-31 21:26 ` Sean Hefty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149107435.7469.7.camel@stevo-desktop \
--to=swise@opengridcomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mshefty@ichips.intel.com \
--cc=netdev@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).