From: Jay Vosburgh <fubar@us.ibm.com>
To: Phil Oester <kernel@linuxace.com>
Cc: =?UTF-8?B?Tmljb2xhcyBkZSBQZXNsb8O8YW4=?=
<nicolas.2p.debian@gmail.com>,
=?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= <mgorny@gentoo.org>,
netdev@vger.kernel.org, roy@marples.name,
"Andy Gospodarek" <andy@greyhouse.net>
Subject: Re: The bonding driver should notify userspace of MAC address change
Date: Fri, 15 Apr 2011 12:22:48 -0700 [thread overview]
Message-ID: <11492.1302895368@death> (raw)
In-Reply-To: <20110415191249.GA6879@linuxace.com>
Phil Oester <kernel@linuxace.com> wrote:
>On Fri, Apr 15, 2011 at 11:53:10AM -0700, Jay Vosburgh wrote:
>> >A bonding device should not report link up to userspace until at least one slave is present and up.
>> >
>> >And possibly, a bonding device should report link down if all slaves are down or all slave were removed.
>> >
>> >Jay, Andy, does this sounds sensible to you?
>>
>> I was just reading their bug and doing an experiment; I don't
>> see that bonding reports carrier up until there's at least one slave
>> (even if it's configured up), e.g.,
>>
>
>This was only recently fixed - see e826eafa65c6f1f7c8db5a237556cebac57ebcc5
>(bonding: Call netif_carrier_off after register_netdevice). Perhaps the
>reporter is not using a recent kernel?
Yah, I looked that up after I'd sent my prior email. Since that
change went in only a month ago, maybe they don't have it.
On the other hand, I did my test on a FC 14 kernel,
2.6.35.6-45.fc14, which claims to have been built in October 2010, and
it seemed to behave properly.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2011-04-15 19:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 16:44 The bonding driver should notify userspace of MAC address change Michał Górny
2011-04-15 18:40 ` Nicolas de Pesloüan
2011-04-15 18:53 ` Jay Vosburgh
2011-04-15 19:10 ` [RFC net-next] bonding: notify when bonding device address changes Stephen Hemminger
2011-04-15 19:28 ` Jay Vosburgh
2011-04-16 16:18 ` Stephen Hemminger
2011-04-15 19:12 ` The bonding driver should notify userspace of MAC address change Phil Oester
2011-04-15 19:22 ` Jay Vosburgh [this message]
2011-04-15 19:22 ` Nicolas de Pesloüan
2011-04-15 21:45 ` Jay Vosburgh
2011-04-16 9:07 ` Nicolas de Pesloüan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11492.1302895368@death \
--to=fubar@us.ibm.com \
--cc=andy@greyhouse.net \
--cc=kernel@linuxace.com \
--cc=mgorny@gentoo.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@gmail.com \
--cc=roy@marples.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).