From: Nathaniel Case <ncase@xes-inc.com>
To: Andy Fleming <afleming@freescale.com>
Cc: netdev@vger.kernel.org, Jeff Garzik <jeff@garzik.org>,
galak@kernel.crashing.org
Subject: [PATCH 0/2] PHYLIB: Fix forcing mode reduction
Date: Mon, 05 Jun 2006 18:45:58 -0500 [thread overview]
Message-ID: <1149551159.10700.46.camel@localhost.localdomain> (raw)
On Mon, 2006-06-05 at 17:08 -0500, Andy Fleming wrote:
> Looks good. Feel free to send these patches to
> netdev@vger.kernel.org (you may need to subscribe), and copy Jeff
> Garzik <jeff@garzik.org>.
This fixes a problem seen when a port without a cable connected would
repeatedly print out "Trying 1000/HALF". While in the PHY_FORCING
state, the call to phy_read_status() was resetting the value of
phydev->speed and phydev->duplex, preventing it from incrementally
trying the speed/duplex variations.
Since we really just want the link status updated for the PHY_FORCING
state, calling genphy_update_link() instead of phy_read_status() fixes
this issue.
Patch tested on a MPC8540 platform with a BCM5421 PHY.
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Andy Fleming <afleming@freescale.com>
---
--- a/drivers/net/phy/phy.c 2006-06-04 16:01:59.000000000 -0500
+++ b/drivers/net/phy/phy.c 2006-06-05 10:55:31.000000000 -0500
@@ -767,7 +783,7 @@
}
break;
case PHY_FORCING:
- err = phy_read_status(phydev);
+ err = genphy_update_link(phydev);
if (err)
break;
--- a/drivers/net/phy/phy_device.c 2006-06-04 16:02:08.000000000 -0500
+++ b/drivers/net/phy/phy_device.c 2006-06-04 19:12:26.000000000 -0500
@@ -417,6 +417,7 @@
return 0;
}
+EXPORT_SYMBOL(genphy_update_link);
/* genphy_read_status
*
next reply other threads:[~2006-06-05 23:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-05 23:45 Nathaniel Case [this message]
2006-07-24 16:40 ` [PATCH 0/2] PHYLIB: Fix forcing mode reduction Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149551159.10700.46.camel@localhost.localdomain \
--to=ncase@xes-inc.com \
--cc=afleming@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox