Netdev List
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: Russell Stuart <russell-tcatm@stuart.id.au>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Stephen Hemminger <shemminger@osdl.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] NET: Accurate packet scheduling for ATM/ADSL (userspace)
Date: Thu, 15 Jun 2006 09:03:11 -0400	[thread overview]
Message-ID: <1150376591.5116.36.camel@jzny2> (raw)
In-Reply-To: <1150332449.8605.40.camel@ras.pc.brisbane.lube>

On Thu, 2006-15-06 at 10:47 +1000, Russell Stuart wrote:
> On Wed, 2006-06-14 at 11:57 +0100, Alan Cox wrote:
> > The other problem I see with this code is it is very tightly tied to ATM
> > cell sizes, not to solving the generic question of packetisation.
> 
> Others have made this point also.  I can't speak for Jesper,
> but I did consider making it generic.  The issue was that 
> doing so would add more code, but I don't personally know 
> of any real world situation that would use the generic 
> solution.  I didn't fancy the thought of arguing on these
> lists for code that no one would actually use.
> 
> If someone could put up their hand and say "Hey, I need
> this," then expanding the patch to accommodate them would
> be a pleasure.  I like generic code too.
> 

It is probably doable by just looking at netdevice->type and figuring
the link layer technology. Totally in user space and building the
compensated for tables there before telling the kernel (advantage is no
kernel changes and therefore it would work with older kernels as well).

cheers,
jamal




  reply	other threads:[~2006-06-15 13:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-14  9:40 [PATCH 2/2] NET: Accurate packet scheduling for ATM/ADSL (userspace) Jesper Dangaard Brouer
2006-06-14 10:57 ` Alan Cox
2006-06-14 13:18   ` Jesper Dangaard Brouer
2006-06-15  0:47   ` Russell Stuart
2006-06-15 13:03     ` jamal [this message]
2006-06-19 19:31       ` Jesper Dangaard Brouer
2006-06-20 14:06         ` jamal
2006-06-20 14:45           ` Patrick McHardy
2006-06-20 15:38             ` jamal
2006-06-20 16:51               ` Patrick McHardy
2006-06-22 19:02                 ` jamal
2006-06-23 15:05                   ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1150376591.5116.36.camel@jzny2 \
    --to=hadi@cyberus.ca \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=russell-tcatm@stuart.id.au \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox