From: jamal <hadi@cyberus.ca>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Robert Olsson <Robert.Olsson@data.slu.se>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [NET]: Prevent multiple qdisc runs
Date: Thu, 22 Jun 2006 20:52:17 -0400 [thread overview]
Message-ID: <1151023937.5099.40.camel@jzny2> (raw)
In-Reply-To: <20060622224302.GA10136@gondor.apana.org.au>
On Fri, 2006-23-06 at 08:43 +1000, Herbert Xu wrote:
> Sure. However, I still don't see the point of transmitting in parallel
> even there. The reason is that there is no work being done here by the
> CPU between dequeueing the packet and obtaining the TX lock.
You make a reasonable argument.
I think I will need to run the experiment to gather facts. I will defer
this discussion until i run some tests or Robert beats me to it.
It does feel like the qdisc_is_running though is now a replacement
for the need for dev->txlock which existed to protect multi-cpus from
entering the device transmit path. Is that unintended side effect?
i.e why would dev->txlock be needed anymore in that path?
cheers,
jamal
next prev parent reply other threads:[~2006-06-23 0:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-19 12:15 [NET]: Prevent multiple qdisc runs Herbert Xu
2006-06-19 13:33 ` jamal
2006-06-19 13:42 ` Herbert Xu
2006-06-19 14:23 ` jamal
2006-06-19 14:29 ` Herbert Xu
2006-06-19 14:36 ` jamal
2006-06-19 22:33 ` Herbert Xu
2006-06-20 14:42 ` jamal
2006-06-20 23:52 ` Herbert Xu
2006-06-22 19:31 ` jamal
2006-06-22 22:43 ` Herbert Xu
2006-06-23 0:52 ` jamal [this message]
2006-06-23 3:35 ` Herbert Xu
2006-06-24 13:50 ` Jamal Hadi Salim
2006-06-20 6:57 ` David Miller
2006-06-20 7:00 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151023937.5099.40.camel@jzny2 \
--to=hadi@cyberus.ca \
--cc=Robert.Olsson@data.slu.se \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox