From: "Michael Chan" <mchan@broadcom.com>
To: "Herbert Xu" <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [3/5] [NET]: Add software TSOv4
Date: Fri, 23 Jun 2006 20:08:41 -0700 [thread overview]
Message-ID: <1151118521.7719.0.camel@rh4> (raw)
In-Reply-To: <20060623235341.GA6593@gondor.apana.org.au>
On Sat, 2006-06-24 at 09:53 +1000, Herbert Xu wrote:
> Nevermind, I obviously complete ignored your other fix to the length of
> the last segment :) Here is a fixed version.
>
> [NET]: Fix CHECKSUM_HW GSO problems.
>
> Fix checksum problems in the GSO code path for CHECKSUM_HW packets.
>
> The ipv4 TCP pseudo header checksum has to be adjusted for GSO
> segmented packets.
>
> The adjustment is needed because the length field in the pseudo-header
> changes. However, because we have the inequality oldlen > newlen, we
> know that delta = (u16)~oldlen + newlen is still a 16-bit quantity.
> This also means that htonl(delta) + th->check still fits in 32 bits.
> Therefore we don't have to use csum_add on this operations.
>
> This is based on a patch by Michael Chan <mchan@broadcom.com>.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
Yes, this should work. ACK.
next prev parent reply other threads:[~2006-06-24 3:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-22 8:12 [0/5] GSO: Generic Segmentation Offload Herbert Xu
2006-06-22 8:12 ` [1/5] [NET]: Merge TSO/UFO fields in sk_buff Herbert Xu
2006-06-22 8:13 ` [2/5] [NET]: Add generic segmentation offload Herbert Xu
2006-06-22 8:14 ` [3/5] [NET]: Add software TSOv4 Herbert Xu
2006-06-22 8:23 ` Herbert Xu
2006-06-22 15:04 ` YOSHIFUJI Hideaki / 吉藤英明
2006-06-22 21:32 ` David Miller
2006-06-24 0:28 ` Ravinandan Arakali
2006-06-24 1:32 ` YOSHIFUJI Hideaki / 吉藤英明
2006-06-26 18:33 ` Ravinandan Arakali
2006-06-23 19:33 ` Michael Chan
2006-06-23 21:26 ` Michael Chan
2006-06-23 23:38 ` Herbert Xu
2006-06-23 23:53 ` Herbert Xu
2006-06-24 3:08 ` Michael Chan [this message]
2006-06-26 6:55 ` David Miller
2006-06-22 8:14 ` [4/5] [NET]: Added GSO toggle Herbert Xu
2006-06-22 8:14 ` [5/5] [IPSEC]: Handle GSO packets Herbert Xu
2006-06-22 8:15 ` [0/5] GSO: Generic Segmentation Offload Herbert Xu
2006-06-22 10:08 ` David Miller
2006-06-22 14:28 ` YOSHIFUJI Hideaki / 吉藤英明
2006-06-24 5:36 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2006-06-20 9:09 Herbert Xu
2006-06-20 9:29 ` [3/5] [NET]: Add software TSOv4 Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151118521.7719.0.camel@rh4 \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).