From: Dan Faerch <dan@scannet.dk>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: akpm@osdl.org, jeff@garzik.org, netdev@vger.kernel.org,
dan@hacker.dk, jgarzik@pobox.com
Subject: Re: [patch 2/3] drivers/net/ns83820.c: add paramter to disable autonegotiation
Date: Tue, 27 Jun 2006 13:43:28 +0200 [thread overview]
Message-ID: <1151408608.20631.28.camel@dan> (raw)
In-Reply-To: <20060626162928.GA22614@kvack.org>
On Mon, 2006-06-26 at 12:29 -0400, Benjamin LaHaise wrote:
> This part is good, although doing something for copper cards needs doing,
> which probably means poking around to support the phy properly.
I Agree. But i dont have a copper card, nor the knowledge to do this. I
was actually hoping that someone could "fill in the blanks".
> > Also added a "disable_autoneg" module argument to completely disable
> > autoneg on all cards using this driver.
>
> This is the part I disagree with. Are you sure it isn't a bug in the
> link autonegotiation state machine for fibre cards? It should be defaulting
> to 1Gbit/full duplex if no autonegotiation is happening, and if it isn't
> then that should be fixed instead of papering over things with a config
> option.
In my setup, we use several fibercards on passive fiber-taps (tx only),
thus there is no link partner. If i dont disable autoneg, i simply cant
sniff traffic.
Skipping the initial autoneg solved the problem. Adding ethtool support
was just an extra courtesy upon request.
After adding ethtool support, i kept the disable_autoneg option to allow
one to operate with default autoneg disabled, and enabling autoneg
through ethtool where needed. Sort of a "reverse operation" mode.
If there IS a bug in the autoneg statemachine i would have no idea how
to fix it. My knowledge of hardware & drivers is unfortunately extremely
limited.
- Dan
prev parent reply other threads:[~2006-06-27 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-25 8:44 [patch 2/3] drivers/net/ns83820.c: add paramter to disable autonegotiation akpm
2006-06-26 16:29 ` Benjamin LaHaise
2006-06-27 11:43 ` Dan Faerch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151408608.20631.28.camel@dan \
--to=dan@scannet.dk \
--cc=akpm@osdl.org \
--cc=bcrl@kvack.org \
--cc=dan@hacker.dk \
--cc=jeff@garzik.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).