From: "Michael Chan" <mchan@broadcom.com>
To: "Herbert Xu" <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [NET]: Added GSO header verification
Date: Tue, 27 Jun 2006 13:46:35 -0700 [thread overview]
Message-ID: <1151441195.3543.3.camel@rh4> (raw)
In-Reply-To: <20060627120714.GA15270@gondor.apana.org.au>
On Tue, 2006-06-27 at 22:07 +1000, Herbert Xu wrote:
> [NET]: Added GSO header verification
>
> @@ -2166,10 +2166,14 @@ struct sk_buff *tcp_tso_segment(struct s
> if (!pskb_may_pull(skb, thlen))
> goto out;
>
> + segs = NULL;
> + if (skb_gso_ok(skb, features | NETIF_F_GSO_ROBUST))
> + goto out;
> +
This logic doesn't look right to me. Perhaps it's backwards and should
be:
if (!skb_gso_ok(skb, features | NETIF_F_GSO_ROBUST))
next prev parent reply other threads:[~2006-06-27 20:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-27 12:07 [NET]: Added GSO header verification Herbert Xu
2006-06-27 20:22 ` David Miller
2006-06-27 20:46 ` Michael Chan [this message]
2006-06-27 22:31 ` Herbert Xu
2006-06-28 2:07 ` Michael Chan
2006-06-29 19:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151441195.3543.3.camel@rh4 \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).