From: "Michael Chan" <mchan@broadcom.com>
To: "Herbert Xu" <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH]NET: Add ECN support for TSO
Date: Tue, 27 Jun 2006 20:40:34 -0700 [thread overview]
Message-ID: <1151466034.5124.18.camel@rh4> (raw)
In-Reply-To: <20060628031052.GA4570@gondor.apana.org.au>
On Wed, 2006-06-28 at 13:10 +1000, Herbert Xu wrote:
> On Tue, Jun 27, 2006 at 08:06:47PM -0700, Michael Chan wrote:
> >
> > diff --git a/include/net/sock.h b/include/net/sock.h
> > index 2d8d6ad..2c75172 100644
> > --- a/include/net/sock.h
> > +++ b/include/net/sock.h
> > @@ -1033,7 +1033,8 @@ static inline void sk_setup_caps(struct
> > if (sk->sk_route_caps & NETIF_F_GSO)
> > sk->sk_route_caps |= NETIF_F_TSO;
> > if (sk->sk_route_caps & NETIF_F_TSO) {
> > - if (sock_flag(sk, SOCK_NO_LARGESEND) || dst->header_len)
> > + if ((sock_flag(sk, SOCK_NO_LARGESEND) &&
> > + !tso_ecn_capable(sk->sk_route_caps)) || dst->header_len)
> > sk->sk_route_caps &= ~NETIF_F_TSO;
>
> Why turn it off? With GSO in place the stack will handle it just fine
> (even your description says so :) We should instead remove all code
> that turns off TSO/ECN when the other is present.
>
We need to turn off NETIF_F_TSO for a connection that has negotiated to
turn on ECN if the output device cannot handle TSO and ECN. In other
words, if the output device does not have either GSO or TSO_ECN feature
set.
next prev parent reply other threads:[~2006-06-28 3:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 3:06 [PATCH]NET: Add ECN support for TSO Michael Chan
2006-06-28 3:10 ` Herbert Xu
2006-06-28 3:40 ` Michael Chan [this message]
2006-06-28 3:48 ` Herbert Xu
2006-06-28 4:37 ` Michael Chan
2006-06-28 4:42 ` Herbert Xu
2006-06-28 4:54 ` Michael Chan
2006-06-28 4:57 ` Herbert Xu
2006-06-29 19:30 ` David Miller
2006-07-07 18:56 ` Ravinandan Arakali
-- strict thread matches above, loose matches on Subject: below --
2006-07-07 20:57 Michael Chan
2006-07-07 21:59 ` David Miller
2006-07-07 22:52 ` David Miller
2006-07-08 1:01 Michael Chan
2006-07-08 20:32 ` David Miller
2006-07-12 1:45 ` Ravinandan Arakali
2006-07-12 1:51 ` David Miller
2006-07-13 17:26 ` Ravinandan Arakali
2006-07-12 4:53 Michael Chan
2006-07-12 6:11 ` David Miller
2006-07-12 17:15 ` Ravinandan Arakali
2006-07-13 19:35 Michael Chan
2006-07-14 5:03 ` David Miller
2006-07-14 16:12 Dan Reader
2006-07-26 19:40 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151466034.5124.18.camel@rh4 \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).