From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bryan O'Sullivan Subject: Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems Date: Thu, 29 Jun 2006 15:01:39 -0700 Message-ID: <1151618499.10886.26.camel@chalcedony.pathscale.com> References: <20060629.145319.71091846.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: akpm@osdl.org, rdreier@cisco.com, mst@mellanox.co.il, openib-general@openib.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Return-path: Received: from mx.pathscale.com ([64.160.42.68]:12178 "EHLO mx.pathscale.com") by vger.kernel.org with ESMTP id S932975AbWF2WBk (ORCPT ); Thu, 29 Jun 2006 18:01:40 -0400 To: David Miller In-Reply-To: <20060629.145319.71091846.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, 2006-06-29 at 14:53 -0700, David Miller wrote: > From: Bryan O'Sullivan > Date: Thu, 29 Jun 2006 14:41:29 -0700 > > > ipath_core-$(CONFIG_X86_64) += ipath_wc_x86_64.o > > +ipath_core-$(CONFIG_PPC64) += ipath_wc_ppc64.o > > Again, don't put these kinds of cpu specific functions > into the infiniband driver. They are potentially globally > useful, not something only Infiniband might want to do. The support for write combining in the kernel is not in a state where that makes any sense at the moment. Also, this is a single-statement function.