Re: [PATCH 0/3] Action API fixes

[jamal <hadi@cyberus.ca>]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

On Thu, 2006-06-07 at 08:03 -0400, jamal wrote:
> On Wed, 2006-05-07 at 20:47 -0700, David Miller wrote:
> > From: Thomas Graf <tgraf@suug.ch>
> > Date: Wed, 05 Jul 2006 00:05:04 +0200
> > 
> > > Fixes for some rather serious action API bugs. Please apply.
> > 
> > All applied, I'll push to -stable, thanks Thomas.
> 
> Dave, Did you actually read my comments on the patches? 
> One patch deserved to go to stable and one was the wrong fix.
> 
> Should i now send a patch against the one?

The proper patch is attached as a replacement for 
"[PATCH 3/3] [PKT_SCHED]: Fix error handling while dumping action"
from Thomas. 
If you have already submitted it, then i will send a patch against it.

cheers,
jamal

[-- Attachment #2: nerr-act --]
[-- Type: text/plain, Size: 462 bytes --]


Fix dumping possibly returning a positive code
Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
---

diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index 2ffa11c..0477c7a 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -259,7 +259,7 @@ tcf_action_dump(struct sk_buff *skb, str
 
 rtattr_failure:
 	skb_trim(skb, b - skb->data);
-	return -err;
+	return -1;
 }
 
 struct tc_action *tcf_action_init_1(struct rtattr *rta, struct rtattr *est,