Bluetooth update for 2.6

Bluetooth update for 2.6

[Marcel Holtmann]

Hi Dave,

this is the second part of pending updates of the Bluetooth subsystem
for the upcoming 2.6.18 kernel. A couple of them are only coding style
cleanups which I failed to submit for the previous kernel release. They
slipped somehow. The rest is driver model integration stuff. Please push
them to Linus as soon as possible.

Regards

Marcel


Please pull from

        git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git

This will update the following files:

 drivers/bluetooth/bfusb.c        |  322 +++++++++++++++++++--------------------
 drivers/bluetooth/hci_ldisc.c    |    4
 drivers/bluetooth/hci_vhci.c     |   97 +++++------
 include/net/bluetooth/hci_core.h |    6
 net/bluetooth/bnep/core.c        |   26 ++-
 net/bluetooth/cmtp/capi.c        |    4
 net/bluetooth/cmtp/core.c        |    3
 net/bluetooth/hci_conn.c         |    8
 net/bluetooth/hci_core.c         |    7
 net/bluetooth/hci_sysfs.c        |  115 +++++++++++--
 net/bluetooth/hidp/core.c        |   26 ++-
 net/bluetooth/rfcomm/core.c      |    9 -
 net/bluetooth/rfcomm/tty.c       |   24 ++
 net/bluetooth/sco.c              |   12 -
 14 files changed, 405 insertions(+), 258 deletions(-)

through these ChangeSets:

Marcel Holtmann <marcel@holtmann.org> Thu, 06 Jul 2006 21:59:00 +0200

    [Bluetooth] Avoid NULL pointer dereference with tty->driver

    This patch checks for tty->driver before trying to call flush_buffer().

    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Thu, 06 Jul 2006 21:58:55 +0200

    [Bluetooth] Code cleanup of the drivers source code

    This patch is an attempt to cleanup the drivers source code to make all
    Bluetooth drivers look more unique.

    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Thu, 06 Jul 2006 21:58:50 +0200

    [Bluetooth] Remaining transitions to use kzalloc()

    This patch makes the remaining transitions to use kzalloc().

    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Thu, 06 Jul 2006 21:58:45 +0200

    [Bluetooth] Integrate services into the driver model

    This patch integrates the services of the Bluetooth protocols RFCOMM,
    BNEP and HIDP into the driver model. This makes it possible to assign
    the virtual TTY, network and input devices to a specific Bluetooth
    connection.

    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Thu, 06 Jul 2006 21:58:40 +0200

    [Bluetooth] Integrate low-level connections into the driver model

    This patch integrates the low-level connections (ACL and SCO) into the
    driver model. Every connection is presented as device with the parent
    set to its host controller device.

    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Thu, 06 Jul 2006 21:58:35 +0200

    [Bluetooth] Remove unused host controller attributes

    This patch removes the unused device attribute entries for the Bluetooth
    host controllers.

    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Re: Bluetooth update for 2.6

[David Miller]

From: Marcel Holtmann <marcel@holtmann.org>
Date: Thu, 06 Jul 2006 22:09:20 +0200

> this is the second part of pending updates of the Bluetooth subsystem
> for the upcoming 2.6.18 kernel. A couple of them are only coding style
> cleanups which I failed to submit for the previous kernel release. They
> slipped somehow. The rest is driver model integration stuff. Please push
> them to Linus as soon as possible.

The merge window for 2.6.18 is closed, so you will need to eliminate
things like code cleanups and other non-bugfixes.

Re: Bluetooth update for 2.6

[Marcel Holtmann]

Hi Dave,

> > this is the second part of pending updates of the Bluetooth subsystem
> > for the upcoming 2.6.18 kernel. A couple of them are only coding style
> > cleanups which I failed to submit for the previous kernel release. They
> > slipped somehow. The rest is driver model integration stuff. Please push
> > them to Linus as soon as possible.
> 
> The merge window for 2.6.18 is closed, so you will need to eliminate
> things like code cleanups and other non-bugfixes.

yes, I saw that, but actually these patches were meant to get to you
before the merge window closed. I failed to prepare the tree, because I
lost remote access to one of my machines were I unfortunately had queued
all of these patches. Do you think Linus will make an exception?

Regards

Marcel

Re: Bluetooth update for 2.6

[David Miller]

From: Marcel Holtmann <marcel@holtmann.org>
Date: Sat, 08 Jul 2006 00:54:30 +0200

> Do you think Linus will make an exception?

I actually hope that he won't.

He even let it go beyond a week this time, it was closer
to 2 weeks.  This gave you ample opportunity to merge your
changes in on time, sorry.

Bluetooth update for 2.6

[Marcel Holtmann]

Hi Dave,

here are some bug fixes for the Bluetooth subsystem. I included the
kzalloc cleanup since I saw you still taking these kind of updates.

Regards

Marcel


Please pull from

        git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git

This will update the following files:

 drivers/bluetooth/hci_ldisc.c |    4 ++--
 net/bluetooth/cmtp/capi.c     |    4 +---
 net/bluetooth/cmtp/core.c     |    3 +--
 net/bluetooth/hci_core.c      |    7 ++-----
 net/bluetooth/hidp/Kconfig    |    3 +--
 net/bluetooth/hidp/core.c     |    3 +--
 net/bluetooth/l2cap.c         |   18 +++++++++---------
 net/bluetooth/rfcomm/core.c   |    9 +++++----
 net/bluetooth/rfcomm/tty.c    |    3 +--
 net/bluetooth/sco.c           |   12 +++++-------
 10 files changed, 28 insertions(+), 38 deletions(-)

through these ChangeSets:

Marcel Holtmann <marcel@holtmann.org> Wed, 12 Jul 2006 23:00:07 +0200

    [Bluetooth] Fix deadlock in the L2CAP layer

    The Bluetooth L2CAP layer has 2 locks that are used in softirq context,
    (one spinlock and one rwlock, where the softirq usage is readlock) but
    where not all usages of the lock were _bh safe. The patch below corrects
    this.

    Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Wed, 12 Jul 2006 22:57:52 +0200

    [Bluetooth] Let BT_HIDP depend on INPUT

    This patch lets BT_HIDP depend on instead of select INPUT. This fixes
    the following warning during an s390 build:

    net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol
    'BT_HIDP' refer to undefined symbol 'INPUT'

    A dependency on INPUT also implies !S390 (and therefore makes the
    explicit dependency obsolete) since INPUT is not available on s390.

    The practical difference should be nearly zero, since INPUT is always
    set to y unless EMBEDDED=y (or S390=y).

    Signed-off-by: Adrian Bunk <bunk@stusta.de>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Thu, 06 Jul 2006 15:53:31 +0200

    [Bluetooth] Avoid NULL pointer dereference with tty->driver

    This patch checks for tty->driver before trying to call flush_buffer().

    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Thu, 06 Jul 2006 15:40:09 +0200

    [Bluetooth] Remaining transitions to use kzalloc()

    This patch makes the remaining transitions to use kzalloc().

    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Re: Bluetooth update for 2.6

[David Miller]

From: Marcel Holtmann <marcel@holtmann.org>
Date: Wed, 12 Jul 2006 23:49:55 +0200

> here are some bug fixes for the Bluetooth subsystem. I included the
> kzalloc cleanup since I saw you still taking these kind of updates.
 ...
> Please pull from
> 
>         git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git

Pulled, thanks a lot!

Bluetooth update for 2.6

[Marcel Holtmann]

Hi Dave,

here are two more bug fixes for the Bluetooth subsystem. Both are
workarounds for either broken implementations or broken hardware.

Regards

Marcel


Please pull from

        git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git

This will update the following files:

 drivers/bluetooth/hci_usb.c |   17 +++++++++++++++--
 net/bluetooth/rfcomm/core.c |   19 +++++++++++++++++--
 2 files changed, 32 insertions(+), 4 deletions(-)

through these ChangeSets:

Marcel Holtmann <marcel@holtmann.org> Fri, 14 Jul 2006 16:01:52 +0200 

    [Bluetooth] Correct SCO buffer size for another Broadcom chip
    
    The SCO buffer size values on IBM/Lenovo ThinkPad laptops with a
    Bluetooth chip from Broadcom are wrong. The USB Bluetooth driver
    has to set a quirk to correct the SCO buffer size values.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Fri, 14 Jul 2006 11:42:12 +0200 

    [Bluetooth] Correct RFCOMM channel MTU for broken implementations
    
    Some Bluetooth RFCOMM implementations try to negotiate a bigger channel
    MTU than we can support for a particular session. The maximum MTU for
    a RFCOMM session is limited through the L2CAP layer. So if the other
    side proposes a channel MTU that is bigger than the underlying L2CAP
    MTU, we should reduce it to the L2CAP MTU of the session minus five
    bytes for the RFCOMM headers.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Re: Bluetooth update for 2.6

[Marcel Holtmann]

Hi Dave,

> here are two more bug fixes for the Bluetooth subsystem. Both are
> workarounds for either broken implementations or broken hardware.

we've seen a bunch of buggy USB Bluetooth devices lately and I have
three more patches to workaround various issues. I also re-based the
tree to 2.6.18-rc2 and pushed the additional changes. Please pull and
forward to Linus as soon as possible.

Regards

Marcel


Please pull from

        git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git

This will update the following files:

 drivers/bluetooth/hci_usb.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

through these ChangeSets:

Marcel Holtmann <marcel@holtmann.org> Tue, 18 Jul 2006 18:32:33 +0200 

    [Bluetooth] Enable SCO support for Broadcom HID proxy dongle
    
    The Broadcom dongles with HID proxy support actually support SCO over
    HCI if the SCO buffer size values are corrected. So instead of disabling
    the SCO support, mark this dongle with the quirk for the Bluetooth core
    to correct the wrong buffer size values.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Tue, 18 Jul 2006 18:04:59 +0200 

    [Bluetooth] Add quirk for another broken RTX Telecom based dongle
    
    This patch disables the ISOC transfers for another broken RTX Telecom
    based USB dongle. Starting the USB ISOC transfers only ends in a burst
    of error messages for invalid SCO packets on connection handle 0.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Tue, 18 Jul 2006 17:47:40 +0200 

    [Bluetooth] Correct SCO buffer size for Belkin devices
    
    The Belkin F8T012 and F8T013 devices are both based on a Bluetooth chip
    from Broadcom and their SCO buffer size values are wrong. The Bluetooth
    core should correct these values.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Bluetooth update for 2.6

[Marcel Holtmann]

Hi Dave,

here are the pending patches that didn't make it into the 2.6.18 kernel
release. I have some additional fixes, but all of them need some more
additional testing from my side.

Regards

Marcel


Please pull from

        git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git

This will update the following files:

 drivers/bluetooth/bfusb.c        |  316 +++++++++++++++++++--------------------
 drivers/bluetooth/hci_ldisc.c    |   13 -
 drivers/bluetooth/hci_usb.c      |    3 
 drivers/bluetooth/hci_vhci.c     |   99 ++++++------
 include/net/bluetooth/hci.h      |    5 
 include/net/bluetooth/hci_core.h |    6 
 net/bluetooth/bnep/core.c        |   26 ++-
 net/bluetooth/hci_conn.c         |    8 
 net/bluetooth/hci_event.c        |    1 
 net/bluetooth/hci_sysfs.c        |  117 ++++++++++++--
 net/bluetooth/hidp/core.c        |   23 ++
 net/bluetooth/rfcomm/tty.c       |   21 ++
 12 files changed, 400 insertions(+), 238 deletions(-)

through these ChangeSets:

Marcel Holtmann <marcel@holtmann.org> Thu, 21 Sep 2006 16:23:19 +0200 

    [Bluetooth] Code cleanup for the HCI UART driver
    
    This patch cleans up the Bluetooth HCI UART driver a bit.
    
    Signed-off-by: Pavel Machek <pavel@suse.cz>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Thu, 21 Sep 2006 16:19:55 +0200 

    [Bluetooth] Add support for Canyon CN-BTU1 dongle
    
    This patch adds the vendor and product id of the Canycon CN-BTU1
    dongle and sets a flag to send HCI_Reset as the first command.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Thu, 21 Sep 2006 16:04:00 +0200 

    [Bluetooth] Handle command complete event for exit periodic inquiry
    
    The command complete event of the exit periodic inquiry command must
    clear the HCI_INQUIRY flag and finish the HCI request.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Sat, 08 Jul 2006 13:57:15 +0200 

    [Bluetooth] Add HCI device identifier for SDIO cards
    
    This patch assigns the next free HCI device identifier to Bluetooth
    devices based on the SDIO interface.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Thu, 06 Jul 2006 15:45:23 +0200 

    [Bluetooth] Code cleanup of the drivers source code
    
    This patch is an attempt to cleanup the drivers source code to make all
    Bluetooth drivers look more unique.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Thu, 06 Jul 2006 13:09:02 +0200 

    [Bluetooth] Integrate services into the driver model
    
    This patch integrates the services of the Bluetooth protocols RFCOMM,
    BNEP and HIDP into the driver model. This makes it possible to assign
    the virtual TTY, network and input devices to a specific Bluetooth
    connection.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Thu, 06 Jul 2006 12:38:46 +0200 

    [Bluetooth] Integrate low-level connections into the driver model
    
    This patch integrates the low-level connections (ACL and SCO) into the
    driver model. Every connection is presented as device with the parent
    set to its host controller device.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Thu, 06 Jul 2006 12:34:41 +0200 

    [Bluetooth] Remove unused host controller attributes
    
    This patch removes the unused device attribute entries for the Bluetooth
    host controllers.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Re: Bluetooth update for 2.6

[Marcel Holtmann]

Hi Dave,

> here are the pending patches that didn't make it into the 2.6.18 kernel
> release. I have some additional fixes, but all of them need some more
> additional testing from my side.

it seems that you haven't pulled in these changes so far. So I didn't
rebase the tree and simply pushed some additional ones on top of it. All
three of them address the issues we had with non-blocking connects.

Regards

Marcel


Please pull from

        git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git

This will update the following files:

 include/net/bluetooth/hci.h      |    6 ++++++
 include/net/bluetooth/hci_core.h |   12 +++++++++---
 net/bluetooth/af_bluetooth.c     |    2 +-
 net/bluetooth/hci_conn.c         |   31 +++++++++++++++++++++++++++----
 net/bluetooth/hci_core.c         |    3 +++
 net/bluetooth/hci_event.c        |   25 ++++++++++++++++++++++++-
 net/bluetooth/hci_sysfs.c        |   24 ++++++++++++++++++++++++
 net/bluetooth/rfcomm/core.c      |    2 +-
 8 files changed, 95 insertions(+), 10 deletions(-)

through these ChangeSets:

Marcel Holtmann <marcel@holtmann.org> Tue, 26 Sep 2006 09:43:48 +0200 

    [Bluetooth] Support create connection cancel command
    
    In case of non-blocking connects it is possible that the last user
    of an ACL link quits before the connection has been fully established.
    This will lead to a race condition where the internal state of a
    connection is closed, but the actual link has been established and is
    active. In case of Bluetooth 1.2 and later devices it is possible to
    call create connection cancel to abort the connect. For older devices
    the disconnect timer will be used to trigger the needed disconnect.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Sat, 23 Sep 2006 09:57:20 +0200 

    [Bluetooth] Read local version information on device init
    
    The local version information are needed to identify certain feature
    sets of devices. They must be read on device init and stored for later
    use. It is also possible to access them through the device model.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Sat, 23 Sep 2006 09:54:38 +0200 

    [Bluetooth] Return EINPROGRESS for non-blocking socket calls
    
    In case of non-blocking socket calls we should return EINPROGRESS
    and not EAGAIN.
    
    Signed-off-by: Ulisses Furquim <ulissesf@gmail.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Re: Bluetooth update for 2.6

[David Miller]

From: Marcel Holtmann <marcel@holtmann.org>
Date: Tue, 26 Sep 2006 12:46:21 +0200

> > here are the pending patches that didn't make it into the 2.6.18 kernel
> > release. I have some additional fixes, but all of them need some more
> > additional testing from my side.
> 
> it seems that you haven't pulled in these changes so far. So I didn't
> rebase the tree and simply pushed some additional ones on top of it. All
> three of them address the issues we had with non-blocking connects.

I applied all of your fixes into my tree, sorry for taking so long.

Re: Bluetooth update for 2.6

[Marcel Holtmann]

Hi Dave,

> > > here are the pending patches that didn't make it into the 2.6.18 kernel
> > > release. I have some additional fixes, but all of them need some more
> > > additional testing from my side.
> > 
> > it seems that you haven't pulled in these changes so far. So I didn't
> > rebase the tree and simply pushed some additional ones on top of it. All
> > three of them address the issues we had with non-blocking connects.
> 
> I applied all of your fixes into my tree, sorry for taking so long.

no big problem. If you haven't synced with Linus yet, then I have two
small additional fixes that should go in with the others.

Regards

Marcel


Please pull from

        git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git

This will update the following files:

 net/bluetooth/hci_event.c |    8 ++++----
 net/bluetooth/hci_sysfs.c |    2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

through these ChangeSets:

Marcel Holtmann <marcel@holtmann.org> Thu, 28 Sep 2006 20:23:29 +0200 

    [Bluetooth] Fix section mismatch of bt_sysfs_cleanup()
    
    The bt_sysfs_cleanup() is marked with __exit attribute, but it will
    be called from an __init function in the error case. So the __exit
    attribute must be removed.
    
    Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Marcel Holtmann <marcel@holtmann.org> Tue, 26 Sep 2006 22:18:03 +0200 

    [Bluetooth] Don't update disconnect timer for incoming connections
    
    In the case of device pairing the only safe method is to establish
    a low-level ACL link. In this case, the remote side should not use
    the disconnect timer to give the other side the chance to enter the
    PIN code. If the disconnect timer is used, the connection will be
    dropped to soon, because it is impossible to identify an actual user
    of this link.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Re: Bluetooth update for 2.6

[David Miller]

From: Marcel Holtmann <marcel@holtmann.org>
Date: Thu, 28 Sep 2006 23:14:44 +0200

> > > > here are the pending patches that didn't make it into the 2.6.18 kernel
> > > > release. I have some additional fixes, but all of them need some more
> > > > additional testing from my side.
> > > 
> > > it seems that you haven't pulled in these changes so far. So I didn't
> > > rebase the tree and simply pushed some additional ones on top of it. All
> > > three of them address the issues we had with non-blocking connects.
> > 
> > I applied all of your fixes into my tree, sorry for taking so long.
> 
> no big problem. If you haven't synced with Linus yet, then I have two
> small additional fixes that should go in with the others.

I've applied these 2 changes as patches to my tree, thanks a lot.

Bluetooth update for 2.6

[Marcel Holtmann]

Hi Dave,

here are my pending bugfixes for the 2.6.19 kernel. They should resolve
various Bugzilla reports and other issues reported over the last couple
of weeks. Please forward them to Linus as soon as possible.

Regards

Marcel


Please pull from

        git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git

This will update the following files:

 drivers/bluetooth/bcm203x.c      |   17 +++-----
 include/net/bluetooth/hci_core.h |   17 ++++++++
 net/bluetooth/af_bluetooth.c     |   38 ++++++++++++++----
 net/bluetooth/bnep/core.c        |    4 -
 net/bluetooth/bnep/sock.c        |   69 ++++++++++++++++++++++++---------
 net/bluetooth/cmtp/sock.c        |   35 ++++++++++++++++-
 net/bluetooth/hci_conn.c         |    6 +-
 net/bluetooth/hci_event.c        |   15 +++++--
 net/bluetooth/hci_sock.c         |    2 
 net/bluetooth/hci_sysfs.c        |   17 ++++----
 net/bluetooth/hidp/core.c        |    8 +--
 net/bluetooth/hidp/sock.c        |   80 ++++++++++++++++++++++++++++++++++++++-
 net/bluetooth/l2cap.c            |    5 +-
 net/bluetooth/rfcomm/core.c      |    3 -
 net/bluetooth/rfcomm/sock.c      |    6 +-
 net/bluetooth/rfcomm/tty.c       |    7 +--
 net/bluetooth/sco.c              |    6 +-
 17 files changed, 264 insertions(+), 71 deletions(-)

through these ChangeSets:

Commit: a712c36b91da9a514b6a0422dc9dcc5bb7ade305 
Author: Marcel Holtmann <marcel@holtmann.org> Sun, 15 Oct 2006 17:31:19 +0200 

    [Bluetooth] Use work queue to trigger URB submission
    
    The bcm203x firmware loading driver uses a timer to trigger the URB
    submission. It is better to use a work queue instead.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Commit: ecf49920b7a4dbd5186a52ea1755f9cd41636e56 
Author: Marcel Holtmann <marcel@holtmann.org> Sun, 15 Oct 2006 17:31:14 +0200 

    [Bluetooth] Add locking for bt_proto array manipulation
    
    The bt_proto array needs to be protected by some kind of locking to
    prevent a race condition between bt_sock_create and bt_sock_register.
    
    And in addition all calls to sk_alloc need to be made GFP_ATOMIC now.
    
    Signed-off-by: Masatake YAMATO <jet@gyve.org>
    Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Commit: f988274ac38b5257eddac8b9d04d471f21691897 
Author: Marcel Holtmann <marcel@holtmann.org> Sun, 15 Oct 2006 17:31:10 +0200 

    [Bluetooth] Check if DLC is still attached to the TTY
    
    If the DLC device is no longer attached to the TTY device, then it
    makes no sense to go through with changing the termios settings.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Commit: fff5558a9c5a03ea5c04eaaac78cf2ca98cce018 
Author: Marcel Holtmann <marcel@holtmann.org> Sun, 15 Oct 2006 17:31:05 +0200 

    [Bluetooth] Fix reference count when connection lookup fails
    
    When the connection lookup for the device structure fails, the reference
    count for the HCI device needs to be decremented.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Commit: a3b3a59dba17ccb9effaa1eb2773e1efbb6ece89 
Author: Marcel Holtmann <marcel@holtmann.org> Sun, 15 Oct 2006 17:31:00 +0200 

    [Bluetooth] Disconnect HID interrupt channel first
    
    The Bluetooth HID specification demands that the interrupt channel
    shall be disconnected first. This is needed to pass the qualification
    tests.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Commit: 49f0ce71de260c6cebf232b7e6865453af9a5056 
Author: Marcel Holtmann <marcel@holtmann.org> Sun, 15 Oct 2006 17:30:56 +0200 

    [Bluetooth] Support concurrent connect requests
    
    Most Bluetooth chips don't support concurrent connect requests, because
    this would involve a multiple baseband page with only one radio. In the
    case an upper layer like L2CAP requests a concurrent connect these chips
    return the error "Command Disallowed" for the second request. If this
    happens it the responsibility of the Bluetooth core to queue the request
    and try again after the previous connect attempt has been completed.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Commit: 8100163b3e5c7d3d248d51b5bcb009c35ea9db63 
Author: Marcel Holtmann <marcel@holtmann.org> Sun, 15 Oct 2006 17:30:50 +0200 

    [Bluetooth] Make use of virtual devices tree
    
    The Bluetooth subsystem currently uses a platform device for devices
    with no parent. It is a better idea to use the new virtual devices
    tree for these.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Commit: c9f320a15ef6d6d31e4063c118ed097266f6be13 
Author: Marcel Holtmann <marcel@holtmann.org> Sun, 15 Oct 2006 17:30:45 +0200 

    [Bluetooth] Handle return values from driver core functions
    
    Some return values of the driver core register and create functions
    are not handled and so might cause unexpected problems.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Commit: 3def4bc6d9f77d4c66298b094ff3723b2a2d23e5 
Author: Marcel Holtmann <marcel@holtmann.org> Sun, 15 Oct 2006 17:30:22 +0200 

    [Bluetooth] Fix compat ioctl for BNEP, CMTP and HIDP
    
    There exists no attempt do deal with the fact that a structure with
    a uint32_t followed by a pointer is going to be different for 32-bit
    and 64-bit userspace. Any 32-bit process trying to use it will be
    failing with -EFAULT if it's lucky; suffering from having data dumped
    at a random address if it's not.
    
    Signed-off-by: David Woodhouse <dwmw2@infradead.org>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Re: Bluetooth update for 2.6

[David Miller]

From: Marcel Holtmann <marcel@holtmann.org>
Date: Sun, 15 Oct 2006 18:10:24 +0200

> Please pull from
> 
>         git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git
> 

Pulled, thanks a lot Marcel.

Bluetooth update for 2.6

[Marcel Holtmann]

Hi Dave,

here are another three bugfixes for the 2.6.19 kernel. Please forward
them to Linus as soon as possible.

Regards

Marcel


Please pull from

        git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git

This will update the following files:

 drivers/bluetooth/dtl1_cs.c |    1 +
 drivers/bluetooth/hci_usb.c |    3 +++
 net/bluetooth/hidp/core.c   |    6 ++----
 3 files changed, 6 insertions(+), 4 deletions(-)

through these ChangeSets:

Commit: 26cd6d320a0c757e26a529fce3b561ff18a14a57 
Author: Marcel Holtmann <marcel@holtmann.org> Fri, 20 Oct 2006 08:55:48 +0200 

    [Bluetooth] Fix HID disconnect NULL pointer dereference
    
    The latest HID disconnect sequence change introduced a NULL pointer
    dereference. For the quirk to handle buggy remote HID implementations,
    it is enough to wait for a potential control channel disconnect from
    the remote side and it is also enough to wait only 500 msecs.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Commit: 7817d1d21393737dddacafa9d229b8431b25e3c3 
Author: Marcel Holtmann <marcel@holtmann.org> Fri, 20 Oct 2006 08:55:34 +0200 

    [Bluetooth] Add missing entry for Nokia DTL-4 PCMCIA card
    
    The device id for the Nokia DTL-4 PCMCIA card was missing. This patch
    adds it back to the list of supported devices.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Commit: f57be46de356456b6eb2d8fb7af1143b4ec7f3cb 
Author: Marcel Holtmann <marcel@holtmann.org> Fri, 20 Oct 2006 08:55:29 +0200 

    [Bluetooth] Add support for newer ANYCOM USB dongles
    
    This patch adds the vendor and product id of the ANYCOM Bluetooth
    USB-200 and USB-250 dongles and sets a flag to send HCI_Reset as
    the first command.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org

Re: Bluetooth update for 2.6

[David Miller]

From: Marcel Holtmann <marcel@holtmann.org>
Date: Fri, 20 Oct 2006 09:49:48 +0200

> Please pull from
> 
>         git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git

I've pulled these patches into my tree, thanks a lot!

Bluetooth update for 2.6

[Marcel Holtmann]

Hi Dave,

here are some additional fixes that should go into 2.6.19 before its
final release. Please forward them to Linus as soon as possible.

Linus, I put you on CC, because Dave might be cross-country driving and
I have no idea when he will be back online.

Regards

Marcel


Please pull from

        git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git

This will update the following files:

 net/bluetooth/hci_event.c  |   19 +++++++++++++++++++
 net/bluetooth/hci_sysfs.c  |    4 +++-
 net/bluetooth/l2cap.c      |   11 +++++++----
 net/bluetooth/rfcomm/tty.c |    2 +-
 4 files changed, 30 insertions(+), 6 deletions(-)

through these ChangeSets:

Commit: 0e040f1bba0ed4421fa5ed7973601b0ec3ce73d1 
Author: Marcel Holtmann <marcel@holtmann.org> Sat, 18 Nov 2006 22:15:20 +0100 

    [Bluetooth] Ignore L2CAP config requests on disconnect
    
    Any L2CAP connection in disconnecting state shall not response
    to any further config requests from the remote side. So in case
    such a request is received, ignore it.
    
    Signed-off-by: Ville Tervo <ville.tervo@nokia.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Commit: e723297071994c1b96c1d7ec5493812a4be14556 
Author: Marcel Holtmann <marcel@holtmann.org> Sat, 18 Nov 2006 22:15:00 +0100 

    [Bluetooth] Always include MTU in L2CAP config responses
    
    When sending a positive config response it shall include the actual
    MTU to be used on this channel. This differs from the Bluetooth 1.1
    specification where it was enough to acknowledge the config request.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Commit: 0fc8b237987d3b7a42813a3ae9ec0fbed9be7a92 
Author: Marcel Holtmann <marcel@holtmann.org> Sat, 18 Nov 2006 22:14:42 +0100 

    [Bluetooth] Check if RFCOMM session is still attached to the TTY
    
    If the RFCOMM session is no longer attached to the TTY device, then it
    makes no sense to go through with changing the termios settings.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Commit: 61f52b9abd9b49770c9b05676fdd36e00999355f 
Author: Marcel Holtmann <marcel@holtmann.org> Sat, 18 Nov 2006 22:14:22 +0100 

    [Bluetooth] Handling pending connect attempts after inquiry
    
    After an inquiry completed or got canceled the Bluetooth core should
    check for any pending connect attempts.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Commit: 3195125e559295126ad21a8552df7328e5c4f507 
Author: Marcel Holtmann <marcel@holtmann.org> Sat, 18 Nov 2006 22:14:05 +0100 

    [Bluetooth] Attach low-level connections to the Bluetooth bus
    
    To receive uvents for the low-level ACL and SCO links, they must be
    assigned to a subsystem. It is enough to attach them to the already
    established Bluetooth bus.
    
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Re: Bluetooth update for 2.6

[David Miller]

From: Marcel Holtmann <marcel@holtmann.org>
Date: Sun, 19 Nov 2006 01:34:33 +0100

> here are some additional fixes that should go into 2.6.19 before its
> final release. Please forward them to Linus as soon as possible.
 ...
> Please pull from
> 
>         git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git

Pulled, thanks a lot Marcel.