From: Martin Josefsson <gandalf@wlug.westbo.se>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] ip multicast route bug fix
Date: Tue, 25 Jul 2006 08:03:00 +0200 [thread overview]
Message-ID: <1153807381.23563.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20060719145716.4cb9e7e2@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 512 bytes --]
On Wed, 2006-07-19 at 14:57 -0700, Stephen Hemminger wrote:
> This should fix the problem reported in http://bugzilla.kernel.org/show_bug.cgi?id=6186
> where the skb is used after freed. The code in IP multicast route.
>
> Code was reusing an skb which could lead to use after free or double free.
> +
> + iskb = alloc_skb(sizeof(struct iphdr), GFP_KERNEL);
> + if (!iskb) {
> + read_unlock(&mrt_lock);
> + return -ENOMEM;
> + }
GFP_KERNEL allocation under read_lock()?
--
/Martin
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-07-25 6:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-19 21:57 [PATCH] ip multicast route bug fix Stephen Hemminger
2006-07-25 5:29 ` James Morris
2006-07-25 6:03 ` Martin Josefsson [this message]
2006-07-25 8:03 ` Herbert Xu
2006-07-25 15:42 ` [PATCH] ip multicast route bug fix (rev2) Stephen Hemminger
2006-07-25 16:20 ` [PATCH] ip multicast route bug fix Alexey Kuznetsov
2006-07-25 15:55 ` Stephen Hemminger
2006-07-25 16:48 ` Alexey Kuznetsov
2006-07-25 18:31 ` Alexey Kuznetsov
2006-07-25 21:17 ` Alexey Kuznetsov
2006-07-25 21:24 ` Stephen Hemminger
2006-07-25 23:45 ` David Miller
2006-07-26 2:26 ` Herbert Xu
2006-07-26 13:27 ` Alexey Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1153807381.23563.2.camel@localhost.localdomain \
--to=gandalf@wlug.westbo.se \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).