From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: Re: [PATCH] net: ethernet: fec: Add missing SPEED_ Date: Sat, 20 Oct 2018 21:26:03 +0200 Message-ID: <1153d0a5-1c23-1e14-7ebd-459886af957a@gmail.com> References: <2621cbc9-47ed-ce2a-b7ee-262f17dc138f@gmail.com> <20181018184715.GA31736@Red> <20181018191612.GB31736@Red> <5cb0731b-83c5-5ed5-d022-98f8627d1737@gmail.com> <20181018195909.GA11317@Red> <1b784f69-3ec2-feb2-81e1-9a335cf477c3@gmail.com> <20181020153922.GC1596@lunn.ch> <20181020185947.GA6615@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Florian Fainelli , LABBE Corentin , davem@davemloft.net, fugang.duan@nxp.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Andrew Lunn Return-path: In-Reply-To: <20181020185947.GA6615@lunn.ch> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 20.10.2018 20:59, Andrew Lunn wrote: >> I dare to dispute here ;) Above code snippet from phy_probe() will >> (try to) set also SUPPORTED_Asym_Pause, because phydrv->features >> doesn't include any of the two pause flags. >> The statement in bcm63xx_config_init you refer to seems to be a >> no-op to me therefore. >> >> I'd say the correct way is to change the PHY config like this: >> .features = PHY_BASIC_FEATURES | SUPPORTED_Pause; >> It's exactly the use case the code snippet above covers. > > Yes, you are correct. > > But it is no longer possible to just do PHY_BASIC_FEATURES | > SUPPORTED_Pause because .features is no loner a u32 but a linux > bitmap. > Ahh, missed that. > We need to keep the same idea, allow the PHY driver to indicate it > supports a subset of Pause, and if not, enable pause by default. > Could the PHY driver define its own bitmap instead of pointing to one of the predefined ones? > Maybe the easiest way is to move this chunk of code to after the probe > function is called. > > Andrew >