Re: [RFC 6/8] NetLabel: CIPSOv4 integration

[Jamal Hadi Salim <hadi@cyberus.ca>]

On Thu, 2006-22-06 at 18:49 -0400, paul.moore@hp.com wrote:
> plain text document attachment (netlabel-cipsov4)
> Add CIPSO/IPv4 support and management to the NetLabel subsystem.  These changes
> integrate the CIPSO/IPv4 configuration into the existing NetLabel code and
> enable the use of CIPSO/IPv4 within the overall NetLabel framework.
> ---
>  net/netlabel/netlabel_cipso_v4.c |  583 +++++++++++++++++++++++++++++++++++++++
>  1 files changed, 583 insertions(+)
> 

> +/**
> + * netlbl_cipsov4_rcv - Process incoming NetLabel packets
> + * @skb: the NETLINK buffer
> + * @msg: pointer to the start of the NetLabel data
> + *
> + * Description:
> + * This function is reponsibile for reading all of the incoming CIPSO V4
> + * NetLabel traffic and dispatching it to the correct CIPSO V4 functions.
> + *
> + */
> +void netlbl_cipsov4_rcv(const struct sk_buff *skb, const unsigned char *msg)
> +{
> +	int ret_val;
> +	struct netlbl_cipsov4_msghdr *nl_cv4_hdr;
> +
> +	if (nlmsg_len((struct nlmsghdr *)skb->data) <
> +	    sizeof(struct netlbl_cipsov4_msghdr)) {
> +		netlbl_cipsov4_send_ack(skb, EINVAL);
> +		return;
> +	}
> +
> +	nl_cv4_hdr = (struct netlbl_cipsov4_msghdr *)msg;
> +	switch (nl_cv4_hdr->opcode) {
> +	case NL_CV4_ADD:

Could you not have had all these NL_CV4_CMDs as just TLVs?
This is just the classical way of how we do things.
This would allow you to send multiple cmds in one message as well as 
very easily add new ones in the future.

BTW, can you please repost your latest changes to netdev?

cheers,
jamal