[patch 0/1]SNMPv2 "ipv6IfStatsInHdrErrors" counter error

[patch 0/1]SNMPv2 "ipv6IfStatsInHdrErrors" counter error

[weidong]

Hi, All
  When I tested Linux kernel 2.6.17.7 about statistics
"ipv6IfStatsInHdrErrors", found that this counter couldn't increase
correctly. The criteria is RFC2465:
  ipv6IfStatsInHdrErrors OBJECT-TYPE
      SYNTAX     Counter3
      MAX-ACCESS read-only
      STATUS     current
      DESCRIPTION
         "The number of input datagrams discarded due to
         errors in their IPv6 headers, including version
         number mismatch, other format errors, hop count
         exceeded, errors discovered in processing their
         IPv6 options, etc."
      ::= { ipv6IfStatsEntry 2 }

When I send TTL=0 and TTL=1 a packet to a router which need to be
forwarded, router just sends an ICMPv6 message to tell the sender that
TIME_EXCEED and HOPLIMITS, but no increments for this counter(in the
function ip6_forward).

The following is the patch for this issue. 

diff -ruN old/net/ipv6/ip6_output.c new/net/ipv6/ip6_output.c
--- old/net/ipv6/ip6_output.c	2006-07-25 11:36:01.000000000 +0800
+++ new/net/ipv6/ip6_output.c	2006-07-31 16:16:13.000000000 +0800
@@ -356,6 +356,7 @@
 		skb->dev = dst->dev;
 		icmpv6_send(skb, ICMPV6_TIME_EXCEED, ICMPV6_EXC_HOPLIMIT,
 			    0, skb->dev);
+		IP6_INC_STATS_BH(IPSTATS_MIB_INHDRERRORS);
 
 		kfree_skb(skb);
 		return -ETIMEDOUT;

signed-off-by:Wei Dong <weid@nanjing-fnst.com>

Regards
Wei Dong

Re: [patch 0/1]SNMPv2 "ipv6IfStatsInHdrErrors" counter error

[YOSHIFUJI Hideaki / 吉藤英明]

Hello.

Next time, please put your "Signed-off-by" line before the patch.
Thank you.

In article <1154425534.3329.2.camel@LINE> (at Tue, 01 Aug 2006 05:45:33 -0400), weidong <weid@nanjing-fnst.com> says:

> signed-off-by:Wei Dong <weid@nanjing-fnst.com>
Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>

--yoshfuji

Re: [patch 0/1]SNMPv2 "ipv6IfStatsInHdrErrors" counter error

[David Miller]

From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Mon, 31 Jul 2006 18:36:25 +0900 (JST)

> Hello.
> 
> Next time, please put your "Signed-off-by" line before the patch.
> Thank you.
> 
> In article <1154425534.3329.2.camel@LINE> (at Tue, 01 Aug 2006 05:45:33 -0400), weidong <weid@nanjing-fnst.com> says:
> 
> > signed-off-by:Wei Dong <weid@nanjing-fnst.com>
> Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>

Patch applied, thanks.