From: Michael Ellerman <michael@ellerman.id.au>
To: Jan-Bernd Themann <ossthema@de.ibm.com>
Cc: Thomas Klein <tklein@de.ibm.com>, netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ppc <linuxppc-dev@ozlabs.org>,
Christoph Raisch <raisch@de.ibm.com>,
Marcus Eder <meder@de.ibm.com>
Subject: Re: [PATCH 1/6] ehea: interface to network stack
Date: Thu, 10 Aug 2006 17:30:50 +1000 [thread overview]
Message-ID: <1155195050.9801.67.camel@localhost.localdomain> (raw)
In-Reply-To: <1155190553.9801.38.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
On Thu, 2006-08-10 at 16:15 +1000, Michael Ellerman wrote:
> > + struct hcp_query_ehea_port_cb_2 *cb2 = NULL;
> > + struct net_device_stats *stats = &port->stats;
> > +
> > + EDEB_EN(7, "net_device=%p", dev);
> > +
> > + cb2 = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
> > + if (!cb2) {
> > + EDEB_ERR(4, "No memory for cb2");
> > + goto get_stat_exit;
>
> You leak cb2 here.
>
> > + }
> > +
> > + hret = ehea_h_query_ehea_port(adapter->handle,
> > + port->logical_port_id,
> > + H_PORT_CB2,
> > + H_PORT_CB2_ALL,
> > + cb2);
> > +
> > + if (hret != H_SUCCESS) {
> > + EDEB_ERR(4, "query_ehea_port failed for cb2");
> > + goto get_stat_exit;
Sorry, here.
cheers
--
Michael Ellerman
IBM OzLabs
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]
next prev parent reply other threads:[~2006-08-10 7:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 8:38 [PATCH 1/6] ehea: interface to network stack Jan-Bernd Themann
2006-08-09 9:08 ` Christian Borntraeger
2006-08-11 11:02 ` Jan-Bernd Themann
2006-08-09 13:06 ` Alexey Dobriyan
2006-08-10 14:49 ` Jan-Bernd Themann
2006-08-10 6:15 ` Michael Ellerman
2006-08-10 7:30 ` Michael Ellerman [this message]
2006-08-10 14:28 ` Jan-Bernd Themann
2006-08-11 20:56 ` Anton Blanchard
2006-08-14 11:26 ` Jörn Engel
2006-08-14 14:38 ` Anton Blanchard
2006-08-14 15:43 ` Jan-Bernd Themann
2006-08-14 16:59 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2006-06-21 12:40 Jan-Bernd Themann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1155195050.9801.67.camel@localhost.localdomain \
--to=michael@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=meder@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).