From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [RFC][PATCH 3/4] deadlock prevention core Date: Sat, 12 Aug 2006 20:08:40 +0200 Message-ID: <1155406120.13508.87.camel@lappy> References: <20060812141415.30842.78695.sendpatchset@lappy> <20060812141445.30842.47336.sendpatchset@lappy> <44640.81.207.0.53.1155403862.squirrel@81.207.0.53> <1155404697.13508.81.camel@lappy> <40048.81.207.0.53.1155405282.squirrel@81.207.0.53> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Evgeniy Polyakov , Daniel Phillips , Rik van Riel , David Miller Return-path: Received: from amsfep17-int.chello.nl ([213.46.243.15]:5779 "EHLO amsfep20-int.chello.nl") by vger.kernel.org with ESMTP id S1030230AbWHLSJ3 (ORCPT ); Sat, 12 Aug 2006 14:09:29 -0400 To: Indan Zupancic In-Reply-To: <40048.81.207.0.53.1155405282.squirrel@81.207.0.53> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sat, 2006-08-12 at 19:54 +0200, Indan Zupancic wrote: > On Sat, August 12, 2006 19:44, Peter Zijlstra said: > > Euhm, right :-) long comes naturaly when I think about quantities op > > pages. The adjust_memalloc_reserve() argument is an increment, a delta; > > perhaps I should change that to long. > > Maybe, but having 16 TB of reserved memory seems plenty for a while. Oh, for sure, but since it doesn't really matter all that much, I'd rather go for proper. > > Having them separate would allow ajust_memalloc_reserve() to be used by > > other callers too (would need some extra locking). > > True, but currently memalloc_reserve isn't used in a sensible way, > or I'm missing something. Well, I'm somewhat reluctant to stick network related code into mm/, it seems well separated now.